Bug 373068 - Custom task editor does not get displayed
Summary: Custom task editor does not get displayed
Status: REOPENED
Alias: None
Product: BPMN2Modeler
Classification: SOA
Component: Extra (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 enhancement with 2 votes (vote)
Target Milestone: 1.3.0-M2   Edit
Assignee: Robert Brodt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-02 06:18 EST by Ana H CLA
Modified: 2016-09-14 10:34 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ana H CLA 2012-03-02 06:18:19 EST
Build Identifier: 20110218-0911

I'm using the Email custom task example (Email.wid). It contains a definition of a custom task editor: 

"eclipse:customEditor" : "org.drools.eclipse.flow.common.editor.editpart.work.EmailCustomEditor"

However I cannot open this editor, I tried double-clicking at a work item. Is there any other way to launch the editor or maybe this feature is not implemented yet?

Reproducible: Always
Comment 1 Robert Brodt CLA 2012-03-02 08:56:25 EST
This has not been implemented yet; work on this is scheduled to start some time after the first community release with jBPM 5.3 in April.
Comment 2 Robert Brodt CLA 2012-04-13 01:52:22 EDT
Partially done. The SampleCustomEditor is used for all Custom Tasks. This allows basic entry of Boolean, Enum, Float, Integer and String data type fields.
Comment 3 Robert Brodt CLA 2013-10-14 10:00:18 EDT
Reopened because I'm not sure if a custom dialog is required here. Currently, the I/O Parameters property tab is used to edit work item properties. If this is not enough, or if custom input validation/constraint needs to be done, we should probably add an editor extension to allow display of a custom input dialog.
Comment 4 Robert Brodt CLA 2016-04-24 13:48:06 EDT
Scheduled for 1.3.0-M2 (Neon)
Comment 5 Jonas Le CLA 2016-06-03 02:05:09 EDT
Do you know if this will make it into Neon?
Comment 6 Robert Brodt CLA 2016-06-03 08:39:34 EDT
I will try to get this in to the June 22 simultaneous release but I don't want to introduce any regressions last minute so I'm not making any promises.
Comment 7 Jonas Le CLA 2016-09-13 03:01:07 EDT
Hi,

sorry for bugging you about this. I saw there were a commit on Github but it seemed to be an incomplete one. If we can help with testing or whatnot, please let me know.
Comment 8 Robert Brodt CLA 2016-09-14 10:34:36 EDT
Hi Jonas,

Adding support for custom editors to the BPMN2 Modeler is a lot more difficult than it seems, not just from a programming point of view but also because of product dependency and licensing issues. The dialog base classes and supporting classes are defined in a Drools library, which are not covered under Eclipse licensing. We would have to either petition the Eclipse Foundation for special consideration of this third party library, or move the jbpm editor extension module under the JBoss/Red Hat umbrella.

The recent changes you're referring to are simply prep work to allow the editor to load and instantiate the external Java classes that implement some dialog interface - there really is nothing new to test here.

I'm still investigating the legal ramifications of all this. Unfortunately I don't have an estimate of when this will happen.