Bug 372918 - WelcomeFileFilter should only activate when there is no valid content
Summary: WelcomeFileFilter should only activate when there is no valid content
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Server (show other bugs)
Version: 0.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 M1   Edit
Assignee: Simon Kaegi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 372954 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-02-29 16:45 EST by Simon Kaegi CLA
Modified: 2012-05-22 11:32 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2012-02-29 16:45:09 EST 
Currently the WelcomeFileFilter redirects requests to folders over aggressively. Instead it should only redirect if the result is no content (404) or the web server forbids folder access (405).
Comment 1 Simon Kaegi CLA 2012-02-29 23:35:25 EST 
This change is responsible for the current server test failures in http://download.eclipse.org/orion/drops/I201202292230/org.eclipse.orion.server.tests.AllServerTests.html

In an app server the welcome file support only becomes active when there is no servlet that is handling the request. We need to find a way to do the same.

I'll see what's possible but barring that I think we'll have to use an include/exclude list.
Comment 2 Simon Kaegi CLA 2012-02-29 23:42:01 EST 
Also to correct above -- I meant 403 Forbidden not 405.
Comment 3 Simon Kaegi CLA 2012-03-01 09:42:05 EST 
*** Bug 372954 has been marked as a duplicate of this bug. ***
Comment 4 Simon Kaegi CLA 2012-05-22 11:32:12 EDT 
This was fixed early in M1.