Bug 372808 - Cross-page links in Programmer's Guide are broken in Firefox
Summary: Cross-page links in Programmer's Guide are broken in Firefox
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Doc (show other bugs)
Version: 0.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 0.5 M1   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on: 372811
Blocks:
  Show dependency tree
 
Reported: 2012-02-28 19:48 EST by Mark Macdonald CLA
Modified: 2012-03-09 14:47 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2012-02-28 19:48:27 EST
2012-02-28-1600

A bunch of subarticles of the "Plugging into the editor" article attempt to link to the 'orion.file.contenttype' service definition. These links are broken.

For example, go to [1] and click the "Content Type IDs" link. It points to [2], which does not exist.

[1] http://orion.eclipse.org/help/topic/org.eclipse.orion.doc.isv/WikiDoc/Orion/Documentation/Developer_Guide/Plugging_into_the_editor/orion-edit-outliner.html?cp=0_0_6_6

[2] http://orion.eclipse.org/help/topic/org.eclipse.orion.doc.isv/WikiDoc/%5COrion%5CDocumentation%5CDeveloper_Guide%5CCore_client_services/orion-file-contenttype.html#orion.file.contenttype
Comment 1 Mark Macdonald CLA 2012-02-28 20:14:20 EST
Actually, this appears to be a more general problem. There are lots more cross-page links that don't work.

For example, go here and click on "text link":
http://orion.eclipse.org/help/topic/org.eclipse.orion.doc.isv/WikiDoc/Orion/Documentation/Developer_Guide/Plugging_into_Orion_pages/orion-core-linkScanner.html?cp=0_0_5_3
Comment 2 Ken Walker CLA 2012-02-28 21:34:33 EST
All of your examples provided actually work for me so I don't see the issue?
Comment 3 Ken Walker CLA 2012-02-28 21:40:33 EST
Tried both Safari and Chrome on Mac and they seemed to work.  I don't get any "topic not found" errors.
Comment 4 Susan McCourt CLA 2012-02-28 21:43:36 EST
works for me on Win7/Chrome but not on Win7/Firefox
Comment 5 Ken Walker CLA 2012-02-28 21:44:10 EST
Ah, it's the Fox.  Just tried that and got "Topic not found".
Comment 6 John Arthorne CLA 2012-02-28 22:03:07 EST
It looks to me like Mark fixed it. I get the broken links on FF. But I pulled the latest from wiki and ran on localhost, and it is fixed. Not quite sure what he did.. looks like he moved a service from one page to another but not sure how that could fix a browser-specific problem.
Comment 7 John Arthorne CLA 2012-02-28 22:08:47 EST
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=38d7d7522be1aba1326b49ac8e2251b05643fa8e

I see weird paths being created in href's with a combination of front and backslash characters. It looks to me like a regression of bug 350460. It might be appearing "fixed" to me on localhost because I'm running a windows server. I'll have to look into it more tomorrow.
Comment 8 Mark Macdonald CLA 2012-02-29 09:19:18 EST
This may be why we don't see the problem on Chrome:
http://code.google.com/p/chromium/issues/detail?id=25916
Comment 9 John Arthorne CLA 2012-02-29 09:35:16 EST
I have entered bug 372811 against WikiText for this. I don't think we're going to be able to fix it for 0.4.
Comment 10 Mark Macdonald CLA 2012-02-29 13:36:46 EST
(In reply to comment #6)
> It looks to me like Mark fixed it. I get the broken links on FF. But I pulled
> the latest from wiki and ran on localhost, and it is fixed. Not quite sure what
> he did.. looks like he moved a service from one page to another but not sure
> how that could fix a browser-specific problem.

For the record, I did this to fix an extension point that I'd mis-documented as a core client service.
Comment 11 John Arthorne CLA 2012-03-09 14:47:02 EST
Fixed by regenerating with the latest wikitext.

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=a90a8ec5c4b0d15c988de717245eac504bed3811