Bug 372803 - Extension Element Search shows wrong match count
Summary: Extension Element Search shows wrong match count
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.8   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.8 M6   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on: 360894
Blocks:
  Show dependency tree
 
Reported: 2012-02-28 16:55 EST by Sascha Becher CLA
Modified: 2012-02-29 12:30 EST (History)
2 users (show)

See Also:

Attachments
Additional changes (2) on top of 211250 (14.74 KB, patch)
2012-02-28 17:10 EST, Sascha Becher CLA 		curtis.windatt.public: iplog+
curtis.windatt.public: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Becher CLA 2012-02-28 16:55:36 EST 
Build Identifier: 

'Search Related' and 'Search with current filter' displays wrong (random) 
match count in Search View. The number of plugins found is required here.

Miscellaneous:
- Extensions search on plugin 'org.eclipse.ui.ide':
  "edit/additions"/org.eclipse.core.runtime.IAdaptable/*ing set/
  accidentially finds also "editing (keyword)" on the extension point
  org.eclipse.ui.keywords
  This is only the case when another attribute in the filter text is 
  quoted and leads to splitting '*ing set' into '*ing' and 'set'.
- Localized attributes should be searched separated and using wildcards:
  '*a task/*old built' on plugin 'org.eclipse.ui.ide' should find 
  'Add a task (command)' and 'Discard old built state (command)'
- Filter text should also filter for element names with wildcards enabled:
  '*definition' on plugin 'org.eclipse.ui' should for example find elements  
  of type (colorDefinition) and (fontDefinition)
  The same goes with extension point names. '*services' on 'org.eclipse.ui'
  needs to find extension point 'org.eclipse.ui.services'
- Some name refactoring is required.

Reproducible: Always
Comment 1 Sascha Becher CLA 2012-02-28 17:10:22 EST 
Created attachment 211768 [details]
Additional changes (2) on top of 211250

Needs to be applied after
Additional changes (1) on top of 211150 of Bug 360894
Comment 2 Curtis Windatt CLA 2012-02-28 17:32:02 EST 
Patches apply cleanly.  I'll do some more testing tomorrow then push the changes.
Comment 3 Curtis Windatt CLA 2012-02-29 12:30:33 EST 
Fixed in master.  Thanks again.