Bug 372765 - Provide accessible way to discover current line
Summary: Provide accessible way to discover current line
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Editor (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 M1   Edit
Assignee: Max Li CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks: 365361
  Show dependency tree
 
Reported: 2012-02-28 11:47 EST by Max Li CLA
Modified: 2012-04-13 15:57 EDT (History)
1 user (show)

See Also:
maxli: review? (Silenio_Quarti)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Max Li CLA 2012-02-28 11:47:05 EST
There is currently no accessible mechanism to find out what the current line is (other than I suppose tabbing out of the editor and reading the top header). 

One possible method (which seems to be already in place on the compare page, but not the editor) is to do so by putting the current line number in the Go to Line field by default (this is also how it is done in desktop Eclipse).
Comment 1 Max Li CLA 2012-03-02 16:18:24 EST
I've implemented the following fix to put the current line number in the Go To Line parameter collector.

The commit is in the bug372765 branch.

https://github.com/max-li/orion.client/commit/4c2a3c2f6a59ed33921cb5348c0a270fff5c3f59
Comment 2 Silenio Quarti CLA 2012-03-06 13:24:35 EST
Pushed to eclipse.org

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=fa60c23e9b21b804483d204f0e52c0651693a44e

Thanks Max. This is a good change not only for accessibility.

I am wondering either the status line (Line: xx Col: xx) could be used for this as well. Could it be a live region for example?
Comment 3 Max Li CLA 2012-03-06 13:47:53 EST
(In reply to comment #2)
> I am wondering either the status line (Line: xx Col: xx) could be used for this
> as well. Could it be a live region for example?

The problem with it being a live region would be that it changes every time the caret is moved. So if we were to set the the status line to be live region that is read (with the property assertive or polite), then it would become a (rather large) nuisance. 

I suppose semantically that the status area should probably be marked as a live region (but with aria-live=off so it doesn't read anything), but it wouldn't provide any new functionality. Either way (with that change or as it is currently), the screen reader still is able to correctly read that text when you move to it.