Bug 372762 - Hide line number ruler from screen readers
Summary: Hide line number ruler from screen readers
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Editor (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 M1   Edit
Assignee: Max Li CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks: 365361
  Show dependency tree
 
Reported: 2012-02-28 11:36 EST by Max Li CLA
Modified: 2012-04-13 15:57 EDT (History)
1 user (show)

See Also:
Silenio_Quarti: review+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Max Li CLA 2012-02-28 11:36:52 EST
Currently, a screen reader will read the line numbers on the editor page (this is particularly evident if you execute a Say All on the page, though I seem to be able to sporadically get it to read it otherwise...possibly my strange combined use of mouse and keyboard). However, the line numbers are held in a different div and thus are read separately from the editor text (essentially, when you get to that portion of the page, the screen reader will just count up from the first line number...not very useful), so there's no real association between a given line number and a line that is read.
Comment 1 Max Li CLA 2012-02-28 15:51:41 EST
Here is a fix.

The commit is in the bug372762 branch.

https://github.com/max-li/orion.client/commit/fc122a117328765684369eb5b7b5a7c9d76ef8cb
Comment 2 Max Li CLA 2012-03-09 15:00:39 EST
I've updated the fix to take into account the new editor changes.

The commit is in the bug372762new branch.

https://github.com/max-li/orion.client/commit/222eb66e092e7118c98d7b52029cc99885966216