Bug 37219 - Rename type should update derived variable name [refactoring]
Summary: Rename type should update derived variable name [refactoring]
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M4   Edit
Assignee: Philip Mayer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 59903 84308 87339 (view as bug list)
Depends on: 110336
Blocks:
  Show dependency tree
 
Reported: 2003-05-05 10:58 EDT by Dirk Baeumer CLA
Modified: 2005-12-13 05:55 EST (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Baeumer CLA 2003-05-05 10:58:28 EDT 
2.1

Rename type Edit to type TextEdit should update variable names of form "Edit 
edit" to "TextEdit textEdit". Name prefixes and suffixes should be considered 
as well.
Comment 1 Dirk Baeumer CLA 2003-05-05 10:58:44 EDT 
3.0 planning.
Comment 2 Dirk Baeumer CLA 2005-02-03 06:00:14 EST 
*** Bug 84308 has been marked as a duplicate of this bug. ***
Comment 3 Dirk Baeumer CLA 2005-03-08 04:12:46 EST 
*** Bug 87339 has been marked as a duplicate of this bug. ***
Comment 4 Eugene Kuleshov CLA 2005-03-08 10:14:03 EST 
Dirk, two years is a long time. Is there are any plans to actually resolve this
in 3.1 stream?
Comment 5 Eugene Kuleshov CLA 2005-03-08 10:17:20 EST 
Just for the record. As I mentioned in 87339, this enhancement should detect a
pertial match such as session for JmsSession, etc.
Comment 6 Dirk Baeumer CLA 2005-03-08 12:48:51 EST 
Unfortunatelly, our current focus for 3.1 is J2SE 5.0. As long as we have open
issues there we will not tackle new feature.
Comment 7 Dirk Baeumer CLA 2005-03-09 08:59:23 EST 
*** Bug 59903 has been marked as a duplicate of this bug. ***
Comment 8 Eugene Kuleshov CLA 2005-03-09 10:36:52 EST 
Another handy feature would be to find methods that return a renamed type and
offer to rename them too if name has complete or partial match with class name.

I also would like to clarify variable renaming. Matching variable names should
include local variables, method parameters and fields. Static field names may
need special handling because of upper case and underscores.
Comment 9 Markus Keller CLA 2005-09-30 05:43:21 EDT 
Reopen.
Comment 10 Markus Keller CLA 2005-12-06 05:52:42 EST 
This has been implemented.

I think all comments have been handled, except for the static fields in comment 8. Please open a separate bug with a concrete example if you think this is an issue.
Comment 11 Channing Walton CLA 2005-12-06 15:30:01 EST 
(In reply to comment #10)
> This has been implemented.

Great, thanks :-)
Comment 12 Benno Baumgartner CLA 2005-12-13 05:31:40 EST 
verifing...
Comment 13 Benno Baumgartner CLA 2005-12-13 05:55:19 EST 
verified in I20051213-0010