Community
Participate
Working Groups
testForcedPush Error expected:<true> but was:<false> java.lang.AssertionError: expected:<true> but was:<false> at org.eclipse.orion.server.tests.servlets.git.GitPushTest.testForcedPush(GitPushTest.java:766) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:501) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:259) at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:36) at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:32) at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:352) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:624) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:579) at org.eclipse.equinox.launcher.Main.run(Main.java:1433) at org.eclipse.equinox.launcher.Main.main(Main.java:1409) at org.eclipse.core.launcher.Main.main(Main.java:34) testForcedFetch Error expected:<true> but was:<false> java.lang.AssertionError: expected:<true> but was:<false> at org.eclipse.orion.server.tests.servlets.git.GitFetchTest.testForcedFetch(GitFetchTest.java:608) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:501) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:259) at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:36) at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:32) at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:352) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:624) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:579) at org.eclipse.equinox.launcher.Main.run(Main.java:1433) at org.eclipse.equinox.launcher.Main.main(Main.java:1409) at org.eclipse.core.launcher.Main.main(Main.java:34)
They both fail expecting forced push to succeed.
Created attachment 211177 [details] Tests improvement I couldn't get them fail when run locally and doing a forced push on orion.eclipse.org worked just fine. I could make the failing tests display more details on failure (ie ServerStatus), see attached patch. I still a +1 for the change, right?
Created attachment 211178 [details] mylyn/context/zip
Giving this a +1 as project lead
Thx, increased tests verbosity in 53bb182e13912f313ca280acd046cc6acac3d884
We have more details now from http://download.eclipse.org/orion/drops/I201202171033/org.eclipse.orion.server.tests.AllServerTests.html : { "Severity":"Warning", "Message":"REJECTED_OTHER_REASON", "HttpCode":500, "Code":0, "JsonData": { "Severity":"Warning", "Message":"REJECTED_OTHER_REASON", "HttpCode":500, "Code":0, "DetailedMessage":"non-fast forward" } }
Weird, we're forcing the push so "not-fast forward" shouldn't be an issue. Moreover, why it's REJECTED_OTHER_REASON with "non-fast forward" message rather than REJECTED_NONFASTFORWARD?
Aha, I bet this is related to bug 343150. The system settings was changed to receive.denyNonFastForward=true just this week. We should be able to override this setting in the local repository, shouldn't we?
Created attachment 211267 [details] mylyn/context/zip
(In reply to comment #8) > The system settings was changed to receive.denyNonFastForward=true Hmm, that would explain a lot, but setting the option [1] locally [2] doesn't seem to harm the failing tests. They all pass. [1] "git config --system receive.denyNonFastforwards true" as root and verified with "git config --system --list" as a regular user [2] I'm on RHEL 5.7 with git 1.7.4.1
Created attachment 211269 [details] Overwrite system settings The good news is that when I set the option in the temp repo that is cloned when running tests they failed with the exact same message. The patch contains two changes: 1. in GitTest imitate the same setup as on eclipse.org when running tests locally 2. in GitFetchTest#testForcedFetch and GitPushTest#testForcedPush overwrite the "system" setting in the cloned repo: enable non fastforwards So, having 1, without 2 applied makes tests fail the same way they do on eclipse.org. Hopefully, having them both applied will make all tests green again.
Great! This is a fix we want in for sure. We need a reviewer and Simon or Me to sign off on it.
Looks good.
As a project lead I +1 this for RC3 Code looks good, fix was tested local by team mirroring the eclipse.org settings and failure without patch and passed with patch.
Thanks guys, the latest patch has been pushed as 029895faf37e80429c2795723e91a2488c802d69
