Bug 371497 - Display active branch in bold
Summary: Display active branch in bold
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Git (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: 0.4 RC3   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2012-02-14 09:32 EST by Tomasz Zarna CLA
Modified: 2012-02-22 05:59 EST (History)
2 users (show)

See Also:
malgorzata.tomczyk: review+


Attachments
mockup (27.91 KB, image/png)
2012-02-15 14:10 EST, Susan McCourt CLA
no flags Details
Fix v1 (3.21 KB, patch)
2012-02-16 06:40 EST, Szymon Brandys CLA
no flags Details | Diff
Active branch icon (891 bytes, image/gif)
2012-02-16 06:41 EST, Szymon Brandys CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2012-02-14 09:32:12 EST
IMO decorating an active branch with "(Active)" is not enough. The branch doesn't stand out, which is particularly cumbersome if you have more then few branches. I would display it in bold.
Comment 1 Szymon Brandys CLA 2012-02-14 10:04:33 EST
I agree that there should be some distinction for the active branch. Susan, what would you suggest here?
Comment 2 Susan McCourt CLA 2012-02-14 10:54:37 EST
I think bolding the branch name and perhaps decorating with an icon.  I mention the icon because a short branch name (master) may still be hard to notice in bold, and I think bolding the descriptive text might be too much.  I would then remove (Active)
Comment 3 Szymon Brandys CLA 2012-02-15 07:37:17 EST
Susan, do we have a good icon to use for .4? Is there still time to request one?
Comment 4 Susan McCourt CLA 2012-02-15 14:06:31 EST
I've just requested one.  
If we don't get it in time, I think we could make one by capturing a "*" character in a gold-ish Orion color.
Comment 5 Susan McCourt CLA 2012-02-15 14:10:52 EST
Created attachment 211065 [details]
mockup

what I sent the designer and what I am imagining  (icon and then bold text)
Comment 6 Szymon Brandys CLA 2012-02-15 17:35:12 EST
Looks good. I will use it for now and replace when we have something from the designer.
Comment 7 Szymon Brandys CLA 2012-02-16 06:40:43 EST
Created attachment 211095 [details]
Fix v1
Comment 8 Szymon Brandys CLA 2012-02-16 06:41:40 EST
Created attachment 211096 [details]
Active branch icon

Copy it to org.eclipse.orion.client.git/web/git/images
Comment 9 Malgorzata Janczarska CLA 2012-02-16 06:51:20 EST
Nice, now you can't miss the active branch :)
Comment 10 Szymon Brandys CLA 2012-02-16 06:54:52 EST
I added the '*' icon and bold text. Waiting for stuff from the designer.
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a8df7003d1a408b08ab5548af46645d6e55e66c8
Comment 11 Susan McCourt CLA 2012-02-16 13:16:24 EST
(In reply to comment #10)
> I added the '*' icon and bold text. Waiting for stuff from the designer.
> http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a8df7003d1a408b08ab5548af46645d6e55e66c8

I hate to be so picky, but can we get rid of the red color?  Red should be urgent/error conditions.  Black bold and an icon is enough, I think...


We have worked very hard to try to eliminate all "extra colors" except when really needed to convey something specific (like red and green for diffs, error/info/warning colors).  Otherwise things are black, shades of gray, orion gold, or link color.  (Post 0.4 I'd like to write up guidelines about all this)
Comment 12 Szymon Brandys CLA 2012-02-17 03:50:28 EST
(In reply to comment #11)
> We have worked very hard to try to eliminate all "extra colors" except when
> really needed to convey something specific (like red and green for diffs,
> error/info/warning colors).  Otherwise things are black, shades of gray, orion
> gold, or link color.  (Post 0.4 I'd like to write up guidelines about all this)

Sure. I used the color from your mockup :) I thought you suggested red on purpose.
Comment 13 Susan McCourt CLA 2012-02-17 11:18:53 EST
(In reply to comment #12)
> (In reply to comment #11)
> > We have worked very hard to try to eliminate all "extra colors" except when
> > really needed to convey something specific (like red and green for diffs,
> > error/info/warning colors).  Otherwise things are black, shades of gray, orion
> > gold, or link color.  (Post 0.4 I'd like to write up guidelines about all this)
> 
> Sure. I used the color from your mockup :) I thought you suggested red on
> purpose.

wow.  the intention was black bold and I guess I was seeing what I thought I did.  Sorry about that, black was the intended color.
Comment 14 Szymon Brandys CLA 2012-02-22 05:59:32 EST
Susan replaced the icon with the one from our designer. Marking the bug fixed.