Bug 370941 - Commit#getTagsForCommit() takes too much time
Summary: Commit#getTagsForCommit() takes too much time
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Git (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.5 M2   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2012-02-08 08:02 EST by Tomasz Zarna CLA
Modified: 2012-05-02 07:42 EDT (History)
0 users

See Also:

Attachments
mylyn/context/zip (4.33 KB, application/octet-stream)
2012-05-02 07:42 EDT, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2012-02-08 08:02:05 EST 
While fixing bug 369709 few performance flaws have been discovered. One of them was Commit#getTagsForCommit(), which takes more time then expected.
Comment 1 Tomasz Zarna CLA 2012-04-03 06:51:10 EDT 
According to profiler calling these methods makes looking for tags so time expensive:
* Repository#getTags(), takes 55%
* RevWalk#parseAny(AnyObjectId), takes 24%
* RevWalk#isMergedInto(RevCommit, RevCommit), takes 20%

They add up to 99%!
Comment 2 Tomasz Zarna CLA 2012-05-02 07:42:45 EDT 
Fixed with a81d61dd633957b0eed584f3dfb27856d3f5c58f
Comment 3 Tomasz Zarna CLA 2012-05-02 07:42:58 EDT 
Created attachment 214913 [details]
mylyn/context/zip