370760 – Command span buttons cannot be used via keyboard

Bug 370760 - Command span buttons cannot be used via keyboard

Summary: Command span buttons cannot be used via keyboard

Status:	RESOLVED FIXED

Alias:	None

Product:	Orion (Archived)
Classification:	ECD
Component:	Client (show other bugs)
Version:	0.4
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	0.4 RC1
Assignee:	Susan McCourt
QA Contact:

URL:
Whiteboard:
Keywords:	accessibility

Depends on:
Blocks:	365361
	Show dependency tree

Reported:	2012-02-06 14:43 EST by Max Li
Modified:	2012-02-10 13:05 EST (History)
CC List:	0 users

See Also:

Flags:	maxli: review?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Max Li

2012-02-06 14:43:47 EST

When attempting to use the command buttons with a keyboard (without a screen reader), such as the top toolbar buttons or the New Branch button on the repositories page, pressing Enter (or Space) has no effect and does not activate the button.

Comment 1 Max Li

2012-02-06 14:49:50 EST

Here is a fix (in the bug370760 branch)

https://github.com/max-li/orion.client/commit/ef9bdff5b92cd7866d17a8553492a91eed5e6402

Comment 2 Susan McCourt

2012-02-06 18:55:00 EST

thanks, Max, for keeping up with the late breaking changes in the command framework.  Does this fix mean I can ignore bug 370229?
(see bug 370229 comment 7).

Comment 3 Max Li

2012-02-07 11:30:13 EST

The fix I have posted only fixes the text buttons. Though I have updated the fix for bug 370229.

Comment 4 Susan McCourt

2012-02-07 12:21:23 EST

fixed.  I did a little merging/rearranging of the commit.

For both _addButton and _addTool we now call the same code, which hooks the onclick as well as the enter/space key handling on the spans.

This will need retesting.
This covers the original problem in bug 370229 (keyboard handling for image tools) but I think you have added some additional stuff, I'll look at that bug next.