Bug 369595 - Javadoc fixes for IClasspathAttribute.SOURCE_ATTACHMENT_ENCODING
Summary: Javadoc fixes for IClasspathAttribute.SOURCE_ATTACHMENT_ENCODING
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.8 M5   Edit
Assignee: Jay Arthanareeswaran CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-24 15:33 EST by Markus Keller CLA
Modified: 2012-01-26 23:07 EST (History)
4 users (show)

See Also:

Attachments
Documentation changes (2.02 KB, patch)
2012-01-25 01:47 EST, Jay Arthanareeswaran CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2012-01-24 15:33:25 EST 
Javadoc of IClasspathAttribute.SOURCE_ATTACHMENT_ENCODING doesn't match the implementation:

- Point 3 should be: If the source attachment is a folder, then the encoding determined by the file content if detectable

- Point 4 misses enclosing folders: If the source attachment is in the workspace, then the encoding of the enclosing resources
Comment 1 Srikanth Sankaran CLA 2012-01-24 15:52:05 EST 
Jay, please follow up. TIA.
Comment 2 Jay Arthanareeswaran CLA 2012-01-25 01:47:28 EST 
Created attachment 210029 [details]
Documentation changes

This patch contains the Javadoc changes suggested by Markus + additional documents/comments corrections in SourceMapper.java
Comment 4 Srikanth Sankaran CLA 2012-01-25 10:49:40 EST 
I eyeballed the commit and it looks good. Build notes still contain 
old details.
Comment 5 Srikanth Sankaran CLA 2012-01-26 23:07:35 EST 
Verified for 3.8 M5 using build id: I20120125-1800