Bug 3695 - memory leak in codeFormatterPreferencePage (1GE6WQU)
Summary: memory leak in codeFormatterPreferencePage (1GE6WQU)
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All Windows NT
: P1 major (vote)
Target Milestone: ---   Edit
Assignee: Erich Gamma CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 22:59 EDT by Erich Gamma CLA
Modified: 2001-10-24 07:17 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erich Gamma CLA 2001-10-10 22:59:21 EDT 
AK (5/23/01 7:42:33 PM)
	CodeFormatterPreferencePage should not hold on to the propertyStore it gets in the initDefaults method
	(or cut the link somewhere)
	a lot of memory cannot be freed because of this

NOTES:
EG (5/28/01 4:59:36 PM)
	The CodeFormatterPreferencePage has life cycle is the same as the workbench. 
	It should be an instance variable not a static variable.

AK (5/29/01 2:52:31 PM)
	this does make a differnce - the class keeps links to things it should not.
	the link is static so it is _never_  released. all the stuff that can be reached from that point will consequently be _never_ freed
	and that's a lot of memory as i saw.

EG (18.07.2001 15:34:24)
	review the code for potential memory leaks and misuse of static instead of instance variables.

MA (09.08.2001 15:19:11)
	reviewed and cleaned up code (200)
Comment 1 Erich Gamma CLA 2001-10-12 06:06:15 EDT 
disposed
Comment 2 DJ Houghton CLA 2001-10-24 07:17:14 EDT 
PRODUCT VERSION:
	110