Bug 366829 - Batch compiler option and SuppressWarnings token for Overriding a Synchronized Method with a Non-synchronized Method
Summary: Batch compiler option and SuppressWarnings token for Overriding a Synchronize...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 3.8 M5   Edit
Assignee: Ayushman Jain CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-15 11:32 EST by Nathan Reynolds CLA
Modified: 2012-01-25 08:39 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan Reynolds CLA 2011-12-15 11:32:12 EST 
Build Identifier: 20110916-0149

Bug 239066 added a compiler warning/error for "Overriding a Synchronized Method with a Non-synchronized Method".  Some code is still thread-safe when being flagged.  There needs to be a SuppressWarnings and quick fix to disable the warning for a particular method.

Reproducible: Always

Steps to Reproduce:
1. Implement the code to reproduce bug 239066
2. Note that there is no quick fix or SuppressWarnings to disable the warning/error
Comment 1 Ayushman Jain CLA 2011-12-15 12:56:27 EST 
Hmm yes the fix missed out the SuppressWarnings token.
Comment 2 Ayushman Jain CLA 2011-12-15 13:54:36 EST 
The batch compiler option and suppress warning token for the warning is 'syncOverride'.

Released fix into master via commit 9fb195845736fa0e0f05bd20b2d3dd774c933577.

Updated the batch compiler doc and released into master via commit 2505474764318d9258f3aacf2d2fcdd0129adbd9
Comment 3 Ayushman Jain CLA 2011-12-15 13:56:52 EST 
(In reply to comment #2)
> Released fix into master via commit 9fb195845736fa0e0f05bd20b2d3dd774c933577.
This is for eclipse.jdt.core repo

> Updated the batch compiler doc and released into master via commit
> 2505474764318d9258f3aacf2d2fcdd0129adbd9
This is for eclipse.platform.common repo.
Comment 4 Satyam Kandula CLA 2012-01-23 11:48:06 EST 
syncOverride is the suppress warning token that has been added as part of this. Other tokens which had multiple words are in the form of x-y. The naming should be consistent.
Comment 5 Ayushman Jain CLA 2012-01-23 12:02:17 EST 
(In reply to comment #4)
> syncOverride is the suppress warning token that has been added as part of this.
> Other tokens which had multiple words are in the form of x-y. The naming should
> be consistent.

Ok I can take care of that for the next build.
Comment 6 Srikanth Sankaran CLA 2012-01-23 19:58:35 EST 
Reopening to get this fixed.
Comment 7 Ayushman Jain CLA 2012-01-24 04:03:25 EST 
Fixed in master with commit 7d0f5fb856e5251bb1177bdff2870292addda9b2
Comment 8 Ayushman Jain CLA 2012-01-24 12:11:35 EST 
I just noticed that this required a doc update too. Done via
commit 3f6cba96b4ca937cc82898c7830eeb1fde9ac00d
Comment 9 Satyam Kandula CLA 2012-01-25 08:39:04 EST 
Verified for 3.8M5 using build I20120124-2000