Comment 1 Satyam Kandula 2011-12-13 10:40:15 EST

Disabled the tests as of now.

Comment 2 Stephan Herrmann 2011-12-13 11:11:50 EST

(In reply to comment #0)
> Newly added tests testUseIndexInternalJarAfterRestart,
> testChangeClasspathForInternalJar, testIndexInJar for predefined indexes failed
> on Mac and Linux.

I can confirm the failures on Linux (2 err, 1 fail).

Let me know if you need help debugging on Linux.

Comment 3 Satyam Kandula 2011-12-13 11:59:01 EST

(In reply to comment #2)
> (In reply to comment #0)
> > Newly added tests testUseIndexInternalJarAfterRestart,
> > testChangeClasspathForInternalJar, testIndexInJar for predefined indexes failed
> > on Mac and Linux.
> 
> I can confirm the failures on Linux (2 err, 1 fail).
> 
> Let me know if you need help debugging on Linux.
Stephan, Thanks for the offer. I think I should be able to take care. I will let you know if I want help.

Comment 4 Satyam Kandula 2011-12-20 07:43:27 EST

testUseIndexInternalJarAfterRestart and testChangeClasspathForInternalJar failed because there is a bug with the way I wrote the test for considering the internal jar. After fixing the test, I found that we weren't handling the internal jar case properly. To fix this, we now keep the list of the index map (jar->index file) in a file, so that on a restart we know the index files used. I actually did this but removed latter assuming that it isn't necessary:(.

testIndexInJar failed because of an extra '/'.

Comment 5 Satyam Kandula 2011-12-20 07:43:50 EST

Created attachment 208603 [details]
Proposed patch

Comment 6 Satyam Kandula 2011-12-20 07:44:23 EST

Jay, Can you please review this?

Comment 7 Jay Arthanareeswaran 2011-12-21 23:48:06 EST

(In reply to comment #5)
> Created attachment 208603 [details]
> Proposed patch

Patch looks good. Just a small point: the indexMaps.length > 0 looks redundant to me.

Comment 8 Satyam Kandula 2012-01-04 01:30:51 EST

(In reply to comment #7)
Thanks Jay, Removed the unnecessary line and released on master via commit 3c9fcd486312b0a7ab40ed5ba3b6e46d9bce5dc9

Comment 9 Stephan Herrmann 2012-01-24 10:13:02 EST

Verified for 3.8 M5 using build I20120123-1300