Bug 365566 - set resource leak diagnostic to "ignore" until bug 358903 is fixed
Summary: set resource leak diagnostic to "ignore" until bug 358903 is fixed
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.8 M4   Edit
Assignee: Ayushman Jain CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-05 05:48 EST by Markus Keller CLA
Modified: 2011-12-06 07:51 EST (History)
6 users (show)

See Also:
stephan.herrmann: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-12-05 05:48:37 EST 
(In reply to bug 358903 comment #13)
> Could we put this and the dependent bugs on the plan for M5?
> 
> The builder has been updated for N20111201-2000, so this will create almost 100
> compiler warnings in the SDK -- and from a quick glance, I'd say about 30% are
> practically unimportant.

We should disable the warning for M4 to avoid generating useless work. After bug 358903 is fixed, the default should go back to "warning".
Comment 1 Ayushman Jain CLA 2011-12-05 06:35:49 EST 
I agree
Running tests. Will release for 1pm build.
Comment 2 Ayushman Jain CLA 2011-12-05 08:50:54 EST 
Changed default to ignore, modified tests.
Fixed with commit b9429071de6b8dc585b9f13f2713b0ebb8eeb99a.

Srikanth, this is a safe fix. Changing the setting to ignore will not produce any extra warnings or change compilation.
Comment 3 Srikanth Sankaran CLA 2011-12-06 01:34:08 EST 
Stephan, please review the changes. TIA.
Comment 4 Srikanth Sankaran CLA 2011-12-06 01:34:57 EST 
Stephan, please add this to your list of fixes to verify and mark
status as VERIFIED after review and testing. Thanks.
Comment 5 Stephan Herrmann CLA 2011-12-06 07:48:59 EST 
Verified for 3.8 M4 using build I20111205-1518

Details:
Patch looks good.
Compiling projects like o.e.jdt.compiler.apt and o.e.jdt.compiler.tool
in the IDE I see no warnings, whereas recent builds (using v_C18)
signal several resource-related warnings.
Warnings come back as expected when explicitly enabling the warning
per project.

Removing bug dependency, as this one is resolved while bug 358903
remains open. In that bug we'll eventually revert this one.