Bug 364890 - BinaryTypeBinding should use char constants from Util
Summary: BinaryTypeBinding should use char constants from Util
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.8   Edit
Hardware: Other Linux
: P3 trivial (vote)
Target Milestone: 3.8 M5   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-26 10:36 EST by Stephan Herrmann CLA
Modified: 2012-01-23 09:45 EST (History)
1 user (show)

See Also:

Attachments
proposed changes (8.91 KB, patch)
2011-11-26 10:40 EST, Stephan Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2011-11-26 10:36:11 EST 
(In reply to bug 186342 comment #150)
> (In reply to bug 186342 comment #146)
> > 1) In
> > org.eclipse.jdt.internal.compiler.lookup.BinaryTypeBinding.scanMethodForNullAnnotation(IBinaryMethod,
> > MethodBinding) and scanTypeForNullAnnotation(..), the constant
> > org.eclipse.jdt.core.Signature.C_RESOLVED should be used instead of character
> > 'L'.
> 
> Even better: org.eclipse.jdt.internal.compiler.util.Util since
> org.eclipse.jdt.core.Signature isn't available for ecj :)
> While we're at it: should I make the same change also for other occurrences
> of 'L' within BinaryTypeBinding?

It turns out, BinaryTypeBinding could use the constants from class Util
in quite a few places.
Comment 1 Stephan Herrmann CLA 2011-11-26 10:40:14 EST 
Created attachment 207566 [details]
proposed changes
Comment 2 Stephan Herrmann CLA 2011-12-22 09:37:45 EST 
Released for 3.8 M5 via commit 6e5a548d86606bf19201f8e25ff7972af2431caf
Comment 3 Ayushman Jain CLA 2012-01-23 09:45:39 EST 
Verified for 3.8M5 using code inspection