Bug 362051 - Filtering doesn't work on selected branches in the Clone wizard
Summary: Filtering doesn't work on selected branches in the Clone wizard
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL: http://egit.eclipse.org/r/4531
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 07:11 EDT by Tomasz Zarna CLA
Modified: 2011-11-15 09:26 EST (History)
4 users (show)

See Also:

Attachments
Screenshot (18.25 KB, image/png)
2011-10-26 07:12 EDT, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-10-26 07:11:35 EDT 
Eclipse I20111025-1325 +  EGit 1.2.0.201110190928

Steps:
1. Import > Git > Projects from Git, Next
2. Clone...
3. Paste a git repo location, Next
4. Wait for remote branches to be read
5. On the Branch Selection page, all branches are selected by default
6. Go straight to the "type filter text" field and enter "master"
=> SHOULD BE: only matched branches should be displayed
=> IS: nothing happens
Comment 1 Tomasz Zarna CLA 2011-10-26 07:12:09 EDT 
Created attachment 205975 [details]
Screenshot
Comment 2 Remy Suen CLA 2011-10-26 20:15:39 EDT 
The tree only filters out items that have not been checked. Personally, I find this behaviour to be completely counterintuitive.
Comment 3 Tomasz Zarna CLA 2011-11-02 05:33:58 EDT 
(In reply to comment #2)
> Personally, I find this behaviour to be completely counterintuitive.

I totally agree! Any idea why it's implemented this way? I can provide a fix for that if it's not an expected behaviour.

Looking for someone to "blame" I found out that Mathias could give us some insight here :)
Comment 4 Mathias Kinzler CLA 2011-11-02 05:38:27 EDT 
(In reply to comment #3)
> (In reply to comment #2)
> > Personally, I find this behaviour to be completely counterintuitive.
> I totally agree! Any idea why it's implemented this way? I can provide a fix
> for that if it's not an expected behaviour.
> Looking for someone to "blame" I found out that Mathias could give us some
> insight here :)

I guess I'm the one to blame... Go forward with a fix.
Comment 5 Remy Suen CLA 2011-11-03 06:34:13 EDT 
*** Bug 307003 has been marked as a duplicate of this bug. ***
Comment 6 Tomasz Zarna CLA 2011-11-03 07:21:52 EDT 
Bug 307003 and this one are both about filtering in the Clone wizard. The other bug is about filtering only unselected projects, while this one is about the same confusing behaviour for branches. Currently, the fix proposed on http://egit.eclipse.org/r/4531 addresses only the branch issue. I can apply the same change for projects if all agree it's ok.
Comment 7 Remy Suen CLA 2011-11-03 07:26:07 EDT 
(In reply to comment #6)
> Bug 307003 and this one are both about filtering in the Clone wizard. The other
> bug is about filtering only unselected projects, while this one is about the
> same confusing behaviour for branches.

I reopened bug 307003 for the sake of posterity (considering they really are talking about two different wizard pages).
Comment 8 Matthias Sohn CLA 2011-11-04 10:14:55 EDT 
merged as 0af999b145ad7124793b0d468652a8818dcba2c7
Comment 9 Dani Megert CLA 2011-11-07 08:15:51 EST 
There are at least two issues with the fix:
1) It does not covert the duplicate bug 307003.
2) Filtering seems to affect the enabled state in the background:
   1. select all
   2. type some filter text
   3. deselect each of the still visible elements
   ==> 'Finish' gets disable, error says that at least one element must selected.
       This is wrong, since there are still other checked elements (but 
       filtered).
Comment 10 Tomasz Zarna CLA 2011-11-07 09:41:37 EST 
(In reply to comment #9)
> 1) It does not covert the duplicate bug 307003

Remy has reopened bug 307003 in comment 7.

> 2) Filtering seems to affect the enabled state in the background:

To make things worse, "Finish" stays disables even then the filter is cleared.

Matthias, should I create a new Change for this?
Comment 11 Tomasz Zarna CLA 2011-11-13 16:39:32 EST 
(In reply to comment #10)
> > 2) Filtering seems to affect the enabled state in the background:
> 
> To make things worse, "Finish" stays disables even then the filter is cleared.

I'm trying to fix that in http://egit.eclipse.org/r/#change,4609. Comments are welcome.
Comment 12 Stefan Lay CLA 2011-11-14 05:04:30 EST 
Fixed with 647df0265fbf606c922a4729bfe873cb65a1abaa
Comment 13 Dani Megert CLA 2011-11-15 09:26:39 EST 
Verified in 1.2.0.201111150513.