Bug 362029 - [builder] ToBeBuilt contains same URI in toBeUpdated and toBeDeleted
Summary: [builder] ToBeBuilt contains same URI in toBeUpdated and toBeDeleted
Status: NEW
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.1.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 02:42 EDT by Knut Wannheden CLA
Modified: 2013-04-22 03:05 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Knut Wannheden CLA 2011-10-26 02:42:05 EDT 
When invoking ToBeBuiltComputer#updateProject() (which happens when a full build is executed) a ToBeBuilt object is returned which contains many URIs both in the toBeUpdated *and* toBeDeleted sets. This seems wrong or at least unnecessary: Either a resource should be updated or deleted.

We should check if we can change the logic in ToBeBuiltComputer (and JdtToBeBuiltComputer) to return ToBeBuilt objects where an URI can only occur in either of the sets. If all tests still are green, I suggest we commit the change.
Comment 1 Sebastian Zarnekow CLA 2011-10-26 02:45:14 EDT 
(In reply to comment #0)
> If all tests still are green, I suggest we commit the change.

Please not before 2.1
Comment 2 Knut Wannheden CLA 2011-10-26 03:24:48 EDT 
(In reply to comment #1)
> Please not before 2.1

Agreed.
Comment 3 Sebastian Zarnekow CLA 2013-04-19 05:44:39 EDT 
Knut, do you remember the impact of the change?
Comment 4 Knut Wannheden CLA 2013-04-19 19:25:25 EDT 
No, I am afraid not. Possibly it doesn't have any effect in the standard builder implementation. I will try to verify that.

Do you think you have found a problem which may be due to this?
Comment 5 Sebastian Zarnekow CLA 2013-04-22 03:05:33 EDT 
No, I did not find a problem related to this behavior, but just stumbled across this ticket while browsing the backlog.