Community
Participate
Working Groups
HEAD package org.test.foobar; /** *{@link org.missing.Foo} */ class Foo { } Copy this into a project. Move this class into a default package in the project. A dialog appears with problems found: Found potential matches. Please preview changes on preview page. However clicking Continue does not show a preview page. The resulting CU I get is /** *{@link missing.Foo} */ class Foo { } I don't know why the @link line gets changed here. So , two problems here: 1) The spurious dialog 2) The changed @link line Fix for bug 241834 seems to have fixed exception but still doesn't look 100% cured to me.
Also doing a CTRL-Z after above steps results in broken comment i.e. linorgk.missing.Foo
I think the problem should be with refactoring.
(In reply to comment #0) > I don't know why the @link line gets changed here. > So , two problems here: > 1) The spurious dialog The dialog is fine, the reference for 'Foo' is the link. (Try searching for reference to Foo in the workspace) > 2) The changed @link line This is also ok. Try with the following snippet where the link is valid to being with and see how it is updated. ------------------------------ package org.test.foobar; /** *{@link org.test.Foo} */ class Foo { } ------------------------------ "org.missing.Foo" is a garbage link and the result is also garbage which fits the garbge in and garbage out principle :-)
(In reply to comment #1) > Also doing a CTRL-Z after above steps results in broken comment > i.e. linorgk.missing.Foo Undo seems to be broken. For me Undo does not do anything. Keeping this bug for the undo problem.
(In reply to comment #3) > "org.missing.Foo" is a garbage link and the result is also garbage which fits > the garbge in and garbage out principle :-) Does not look like a very reasonable argument. Why can't the garbage be just left alone? How does "org.missing.Foo" get messed up into some other string?
(In reply to comment #5) > Does not look like a very reasonable argument. Why can't the garbage be just > left alone? How does "org.missing.Foo" get messed up into some other string? It is not messed up. If you start with link as "org.test.Foo", it is updated to "Foo". But if you start with "org.missing.Foo" the refactoring tries to update it but does not get very far as the link is not valid and it cannot understand 'missing' and hence leaves it as is.
The handling of potential matches is not great, see bug 198921.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
