Community
Participate
Working Groups
1.2.0.201110111814 Preference changes not stored after clicking 'OK' or pressing 'Enter'. 1. start new workspace 2. enter user.name and user.email in Git > Configuration 3. reopen Git > Configuration 4. select 'name' 5. enter a new name into the 'Value:' field (not leave the field) 6. click 'OK' or press 'Enter' 7. reopen Git > Configuration ==> BAD: changes are not there This is 'major'. Due to this my wrong name ended up in the shared repository.
We have several possible ways to fix this: 1) We get rid of the 'Change' button all together and update on focus lost. 2 We don't check the dirty state in GlobalConfigurationPreferencePage.performOk(). Not sure whether always saving the values has any side-effect though (e.g. notified listeners could cause a performance hit). 3) We introduce a protocol that allows to notify the ConfigurationEditorComponent when applying or OKing the outer composite. What do you prefer?
What do you think about using a cell editor and changing things directly in the tree?
(In reply to comment #2) > What do you think about using a cell editor and changing things directly in the > tree? Would this solution be keyboard accessible?
(In reply to comment #2) > What do you think about using a cell editor and changing things directly in the > tree? Last time I used cell editors they weren't too developer friendly (i.e. needs quite some work to get it done right). Not sure whether that changed. (In reply to comment #3) > Would this solution be keyboard accessible? AFAIK this isn't an issue. Each OS has its native key binding to activate the cell editing (e.g. 'Enter' on Windows).
