Bug 360868 - Show In > History on a commit/tag/branch does not work
Summary: Show In > History on a commit/tag/branch does not work
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 5.5   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2011-10-13 12:32 EDT by Deepak Azad CLA
Modified: 2019-07-07 12:49 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Deepak Azad CLA 2011-10-13 12:32:10 EDT 
Eclipse 4.2 - I20111007-1625 and EGit - 1.2.0.201110091909

'Git Seach' and click 'Show In > History' on a commit in the search result list
=>  It just brings up the history view, but does not highlight or navigate to the commit (like the find toolbar).
Comment 1 Dani Megert CLA 2012-08-21 09:51:27 EDT 
Still a problem in latest EGit builds.
Comment 2 Dani Megert CLA 2013-01-14 08:15:07 EST 
It works if all branches are shown. The GitHistoryPage should show a dialog and ask whether to remove the filter.
Comment 3 Markus Keller CLA 2014-02-19 08:45:50 EST 
It would be better if the selection in the Git Repositories view would also modify the History view input so that commits for the selected branches are shown (only temporarily, until a new History view input is set).

I don't think a dialog is necessary. EGit also doesn't show a dialog when the History view is filtered to a specific file.

See also bug 381520 (asks for an explicit permanent selection of refs to show).
Comment 4 Eclipse Genie CLA 2019-07-06 14:06:00 EDT 
New Gerrit change created: https://git.eclipse.org/r/145568
Comment 5 Eclipse Genie CLA 2019-07-07 12:40:37 EDT 
Gerrit change https://git.eclipse.org/r/145568 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=10293f9f0c3739a66e772d7cd3e7560f7c4b7ccd
Comment 6 Thomas Wolf CLA 2019-07-07 12:49:29 EDT 
If the commit history is limited (See Preferences->Team->Git->History, "Maximum number of commits to show") and the selected branch, tag, or commit is beyond this cut-off, it is still _not_ shown.

That was a conscious implementation decision; if the user set a low limit, he or she probably had reasons to do so, and thus respecting this limit instead of going on until the wanted commit was included in the list seemed prudent.