Bug 360740 - Potential memory leak within ScrollableThumbnail
Summary: Potential memory leak within ScrollableThumbnail
Status: RESOLVED FIXED
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy Draw2d (show other bugs)
Version: 3.7.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7.2 (Indigo SR2)   Edit
Assignee: Alexander Nyßen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 168799
  Show dependency tree
 
Reported: 2011-10-12 18:17 EDT by Alexander Nyßen CLA
Modified: 2011-10-12 18:32 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Nyßen CLA 2011-10-12 18:17:54 EDT 
The syncher and keyListener, which are registered on the selector figure during initialization, don't get unregistered upon deactivation. Up to now this does not seem to be harmful (as both are local instances that are not exposed), but leaving a clean state doesn't do any harm either, thereby preventing potential memory leaks that may be caused by changes in the future.
Comment 1 Alexander Nyßen CLA 2011-10-12 18:30:39 EDT 
Introduced private hookSelector(), unhookSelector(), hookViewport(), and unhookViewport() methods that get called during initialization and deactivation respectively. Changed SelectorFigure to no longer cache the image but only the underlying image data, so it no longer required a dispose().

Committed changes to cvs HEAD (3.8) as well as R_3_7_maintenance branch. Resolving as fixed in 3.7.2.