Bug 359963 - [CompositeDiagram] Remove Scrollbar for compartment
Summary: [CompositeDiagram] Remove Scrollbar for compartment
Status: REOPENED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Patrick Tessier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-05 07:31 EDT by Patrick Tessier CLA
Modified: 2017-08-02 11:36 EDT (History)
3 users (show)

See Also:


Attachments
IncorrectFeedback (310.21 KB, image/jpeg)
2011-11-02 12:16 EDT, Yann Tanguy CLA
no flags Details
Partially_hidden_content (8.85 KB, image/jpeg)
2011-11-02 12:16 EDT, Yann Tanguy CLA
no flags Details
Property_moved_outside_container (15.05 KB, image/jpeg)
2011-11-02 12:16 EDT, Yann Tanguy CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Tessier CLA 2011-10-05 07:31:55 EDT
The composite diagram must not contain scrollbar
Comment 1 Patrick Tessier CLA 2011-10-05 07:35:40 EDT
Explanation about how to do this functionality has been added in the wiki :
http://wiki.eclipse.org/Papyrus_Developer_Guide/NoScrollbar

generic classes added in the diagram.common (rev 5703)
Comment 2 Patrick Tessier CLA 2011-10-05 07:53:27 EDT
committed in the branch (rev 5706)
Comment 3 Patrick Tessier CLA 2011-10-06 04:18:54 EDT
the merge has been done for the diagram common in the head (rev 5724)
Comment 4 Patrick Tessier CLA 2011-10-06 04:38:47 EDT
the merge has been done for the diagram composite in the head (rev 5725)
Comment 5 Yann Tanguy CLA 2011-10-11 07:51:02 EDT
The feedback during move attempt does not appear to be correct (a part of the contained figure appears outside its owner).
The autosize mode does not work correctly with this implementation, it is allowed or not depending on the gesture (ex: move on the left ok, move on the right nok) which lead to a somehow unpredictable behavior...

Note that I currently have some troubles with the autosize mode (see. bug#360451) relatively to Port location in general and FlowPort graphical appearance more specifically.
Comment 6 Yann Tanguy CLA 2011-10-11 09:27:56 EDT
(In reply to comment #5)
> The feedback during move attempt does not appear to be correct (a part of the
> contained figure appears outside its owner).
> The autosize mode does not work correctly with this implementation, it is
> allowed or not depending on the gesture (ex: move on the left ok, move on the
> right nok) which lead to a somehow unpredictable behavior...

The container can also be resized in a way that mask the content (without scrollbars, there is no way to know that such contained element has been masked).
The resize from top-left toward the bottom-right diagonal can result in a container resize.
Comment 7 Patrick Tessier CLA 2011-10-20 08:13:02 EDT
>The feedback during move attempt does not appear to be correct (a part of the contained figure appears outside its owner).
It is peculiar, could you explain the condition to execute this behavior, because I cannot reproduce it.
>The autosize mode does not work correctly with this implementation, it is allowed or not depending on the gesture (ex: move on the left ok, move on the right nok) which lead to a somehow unpredictable behavior...
I have not this bug

>The container can also be resized in a way that mask the content (without scrollbars, there is no way to know that such contained element has been masked).
>The resize from top-left toward the bottom-right diagonal can result in a container resize.
In fact, I have take in account this behavior
Comment 8 Yann Tanguy CLA 2011-11-02 12:15:20 EDT
(In reply to comment #7)
> >The feedback during move attempt does not appear to be correct (a part of the
> contained figure appears outside its owner).
> It is peculiar, could you explain the condition to execute this behavior,
> because I cannot reproduce it.

Create a Class, a Property then move the property... I have Papyrus nightly 201111011738 installed, i'll add a screen capture for this.

> >The autosize mode does not work correctly with this implementation, it is
> allowed or not depending on the gesture (ex: move on the left ok, move on the
> right nok) which lead to a somehow unpredictable behavior...
> I have not this bug
> 
Sorry move down not left, this is probably more or less related to the previous bug.
Create a Class add a Property, switch the Class to autosize mode and try to move the Property. When you go down the Class can be resize, not when you move the Property to the left or right.

> >The container can also be resized in a way that mask the content (without
> scrollbars, there is no way to know that such contained element has been
> masked).
> >The resize from top-left toward the bottom-right diagonal can result in a
> container resize.
> In fact, I have take in account this behavior

I dont think so, these bugs are still existing in current version.
Comment 9 Yann Tanguy CLA 2011-11-02 12:16:00 EDT
Created attachment 206346 [details]
IncorrectFeedback
Comment 10 Yann Tanguy CLA 2011-11-02 12:16:21 EDT
Created attachment 206347 [details]
Partially_hidden_content
Comment 11 Yann Tanguy CLA 2011-11-02 12:16:56 EDT
Created attachment 206348 [details]
Property_moved_outside_container
Comment 12 Alain Le Guennec CLA 2011-11-06 08:12:38 EST
Will you implement scrollbar removal for SysML Internal Block Diagrams too?
(it seems to work fairly well for composite structure diagrams now, but IBDs still have scrollbars unfortunately).
Comment 13 Yann Tanguy CLA 2011-11-07 03:53:22 EST
(In reply to comment #12)
> Will you implement scrollbar removal for SysML Internal Block Diagrams too?
> (it seems to work fairly well for composite structure diagrams now, but IBDs
> still have scrollbars unfortunately).

There are still several issues to fix (see previous comments) before implementing this in IBD.
Comment 14 Patrick Tessier CLA 2011-11-09 04:45:31 EST
I have fixed the first point about the resize and the move of a child.

About the second point autosize, I will open a new bug because this bug remains with scroll bars.

It remains to work on the third point : resize of the parent.

(done on the branch revision 6211)
Comment 15 Yann Tanguy CLA 2011-11-09 05:03:28 EST
(In reply to comment #14)
> I have fixed the first point about the resize and the move of a child.
> 
> About the second point autosize, I will open a new bug because this bug remains
> with scroll bars.
> 
> It remains to work on the third point : resize of the parent.
> 
> (done on the branch revision 6211)

Also related to this bug, I suspect Papyrus layout to be incompatible with this in the sense that parent and children are move without taking into account the behavior provided by edit parts. Can you test this ? Are these layout implemented with GMF layout service ?
Comment 16 Patrick Tessier CLA 2011-12-01 05:13:32 EST
The code introduced to do the fucntionnality remove Scrollbar has been removed in the branch.
revision 6334