Bug 359831 - Fix messages for "new warning for missing try-with-resources"
Summary: Fix messages for "new warning for missing try-with-resources"
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows 7
: P3 trivial (vote)
Target Milestone: 3.8 M3   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-04 08:57 EDT by Markus Keller CLA
Modified: 2011-10-24 16:52 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-10-04 08:57:08 EDT 
Follow-up to bug 349326

The messages 885 to 889 in /org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/problem/messages.properties originally contained '{0}', which caused CHKPII errors:

'{0}' will be resolved to the literal text: {0}.  If replaced text is supposed to be enclosed in single quotes, use ''{0}''.  Line 649

In master, the last commit changed this to "{0}", which is not the style we use. Please change to ''{0}'' (two single quotes).
Comment 1 Olivier Thomann CLA 2011-10-04 09:26:54 EDT 
I'll fix it as I am also fixing small chkpii errors inside the buildnotes.
Comment 2 Markus Keller CLA 2011-10-04 09:40:06 EDT 
I also saw some missing encodings in the headers of test.xml files:

Was:      <?xml version="1.0"?>
Expected: <?xml version="1.0" encoding="UTF-8"?>
Comment 3 Olivier Thomann CLA 2011-10-04 09:58:16 EDT 
Fix for 3.8M3.
Commit     41a0b6a0e7fdff11d3aeb623a16808263b38f6e3
Comment 4 Markus Keller CLA 2011-10-10 07:02:06 EDT 
Fixed one more encoding="UTF-8" and mixed line delimiters.

Commit 60bafa120d7812956042143e5d3c952c6141029e
Comment 5 Ayushman Jain CLA 2011-10-24 16:52:52 EDT 
Verified using code inspection.