Bug 359739 - Allow * and ? wildcards by default in search
Summary: Allow * and ? wildcards by default in search
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 359766
Blocks:
  Show dependency tree
 
Reported: 2011-10-03 13:08 EDT by John Arthorne CLA
Modified: 2011-11-16 10:04 EST (History)
2 users (show)

See Also:


Attachments
affordance text in Windows explorer search box (20.45 KB, image/png)
2011-11-15 14:28 EST, John Arthorne CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-10-03 13:08:12 EDT
0.3 M2

We are currently escaping all special characters in the search box, including * and ?. I think we should be consistent with Eclipse search and support * and ? wildcards by default, allowing them to be escaped via \* and \?.
Comment 1 John Arthorne CLA 2011-10-03 13:30:50 EDT
Libing, if I change this on the server we would need to be consistent in the client-side post-processing. Does this change make sense to you?
Comment 2 John Arthorne CLA 2011-10-03 13:31:38 EDT
If we do this, we should explain that wildcards are supported using a tooltip on the search text field.
Comment 3 libing wang CLA 2011-10-03 14:58:14 EDT
(In reply to comment #1)
> Libing, if I change this on the server we would need to be consistent in the
> client-side post-processing. Does this change make sense to you?

Currently, client uses simplest string search(string.indexOf) for inside-file search. For wild card search, I have to change that by using reg ex.
Comment 4 John Arthorne CLA 2011-10-03 15:02:21 EDT
It's something we could move to 0.4 if it is complicated. On the server it already works, it just depends on whether you escape the wildcard character on the client before sending the query.
Comment 5 libing wang CLA 2011-10-03 15:14:34 EDT
(In reply to comment #4)
> It's something we could move to 0.4 if it is complicated. On the server it
> already works, it just depends on whether you escape the wildcard character on
> the client before sending the query.

I just gave it a quick try on something like "text*view", server did respond something but client gave 0 match.
I think for 0.3 the bottom line is to escape those * and ?.
Comment 6 libing wang CLA 2011-11-08 16:37:36 EST
fixed with 5d32838a0c5800ddd8e99ea351f2e41299e1e1c1.
Comment 7 libing wang CLA 2011-11-08 16:40:00 EST
There is a tool tip now on the search box: "Type a keyword or wild card to search", and place holder :"Search".
If any one has good idea about indicating wild card search please comment.
Comment 8 Susan McCourt CLA 2011-11-15 11:51:07 EST
(In reply to comment #7)
> There is a tool tip now on the search box: "Type a keyword or wild card to
> search", and place holder :"Search".
> If any one has good idea about indicating wild card search please comment.

I think this comment belongs in another bug (where search scope text was added to the search box) but I can't find that bug (sorry).  

I think it's confusing to have the search scope showing in the box, especially the one that says "Search root".

I suggest we always just have "Search" in the box.
And then the tooltip can give the scope.  
I also suggest we simplify the tooltip to say
"Search in <scope>"

and then the results page can talk about wildcards, etc.

I think most people assume they can type wildcards and then if they want to know how to use search they go to the advanced page.

For something in the header, I think the text and tooltips need to be as simple/terse as possible to reduce noise.
Comment 9 John Arthorne CLA 2011-11-15 14:28:46 EST
Created attachment 207047 [details]
affordance text in Windows explorer search box
Comment 10 John Arthorne CLA 2011-11-15 14:31:47 EST
(In reply to comment #8)
> I think it's confusing to have the search scope showing in the box, especially
> the one that says "Search root".
> 
> I suggest we always just have "Search" in the box.
> And then the tooltip can give the scope.  
> I also suggest we simplify the tooltip to say
> "Search in <scope>"

I agree about the root case. Maybe for the root we just say "Search". But for other folders I think it is a useful affordance to tell the user that the search they are performing here is scoped. This isn't immediately obvious as often a search bar at the top is a global search unless otherwise configured (think web browsers). I remember noticing this recently in Windows 7 (see attachment) and without it I would have assumed the search bar was global. If the user doesn't realize their search was scoped they might be frustrated by not finding the results they expect.
Comment 11 Susan McCourt CLA 2011-11-15 16:48:31 EST
Maybe making the search box wider would help.  The windows one has never seemed funny looking to me, while this one does.  (Or maybe I'm just used to it being empty).
Comment 12 libing wang CLA 2011-11-16 10:04:19 EST
(In reply to comment #11)
> Maybe making the search box wider would help.  The windows one has never seemed
> funny looking to me, while this one does.  (Or maybe I'm just used to it being
> empty).

Bug 363740 is the original one addressing tool tip and place holder.
I am adding bug 363740 comment 3 there.