Bug 359619 - "Navigator Root" is the first item in breadcrumb
Summary: "Navigator Root" is the first item in breadcrumb
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 0.3   Edit
Hardware: PC All
: P3 minor (vote)
Target Milestone: 0.3 RC1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 357828 (view as bug list)
Depends on:
Blocks: 359762
  Show dependency tree
 
Reported: 2011-09-30 16:39 EDT by Mark Macdonald CLA
Modified: 2011-10-27 15:53 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2011-09-30 16:39:50 EDT
orion.eclipse.org 0.2.0.v20110929-2021

The Navigator used to display "[Your User Name]/" as the top-level breadcrumb item. Now it displays "Navigator Root/". Was this a conscious decision or an accident? I preferred the having my user name there...
Comment 1 Susan McCourt CLA 2011-10-03 11:00:58 EDT
that sounds like a bug, there may still be code that defaults to "navigator root" if nothing else is set.  I'll look at it.
Comment 2 Susan McCourt CLA 2011-10-03 13:00:19 EDT
fixed with
b4004822858a0fdf97622824b9806f10534f3bfd

Somewhere along the line we lost the code in globalCommands that cached the user name when getting credentials.  Most of this behavior has been moved into the LoginDialog widget, so I added the caching code there.
Comment 3 John Arthorne CLA 2011-10-03 14:04:47 EDT
This might have been intentional. This doesn't work for an OpenID login. In this case the user name is something like:

https://www.google.com/accounts/o8/id?id=AItOawmUjTbNFvPVJWoeDEBKrshmQrCIxzIuWeA
Comment 4 John Arthorne CLA 2011-10-03 14:20:43 EDT
I also wonder if a hyperlink to my user name is intuitively my "root folder". I guess this idea comes from github, but in that case the root has more user profile information (followers, member since, etc).
Comment 5 Susan McCourt CLA 2011-10-03 15:33:23 EDT
when we have multiple file services (with potentially different logins) this could get more confusing.  

But I do not like "Navigator Root" either.  for now I will change it to "Navigator" and we can think about more long term niceties in bug 349531.
Comment 6 Susan McCourt CLA 2011-10-03 15:54:26 EDT
(In reply to comment #5)
> when we have multiple file services (with potentially different logins) this
> could get more confusing.  
> 
> But I do not like "Navigator Root" either.  for now I will change it to
> "Navigator" and we can think about more long term niceties in bug 349531.

Actually, it looked really dumb to see

Navigator
Navigator

in the page heading.  I tried all kinds of cool ideas for the root. 
/
(root)
folders

etc.

They all had problems, so for now I've gone back to "root" even though that seems bogus, too.

I kept the code that caches the user name because as long as we keep the user service around, we should make sure it works.
Comment 7 Szymon Brandys CLA 2011-10-04 04:17:19 EDT
(In reply to comment #3)
> This might have been intentional. This doesn't work for an OpenID login. In
> this case the user name is something like:
> 
> https://www.google.com/accounts/o8/id?id=AItOawmUjTbNFvPVJWoeDEBKrshmQrCIxzIuWeA

Right. For users logged in via OpenID the initial name in their profiles is something like https://www.google.com/accounts/o8/id?id=AItOawmUjTbNFvPVJWoeDEBKrshmQrCIxzIuWeA. And the name used to be displayed in breadcrumbs.

Users may change it later for something human-readable.

What I would suggest is to not populate the name in the profile for OpenID logins. The user would have to enter it manually. Then if the name is set, we would display it. If not, we would just display "You", "Root" etc.

So for profiles with names it would be: Susan/myFolder/a.txt, for profiles without it: You/myFolder/a.txt.

Susan, do we have a bug for further work on it?
Comment 8 Susan McCourt CLA 2011-10-04 12:35:02 EDT
(In reply to comment #7)

> Susan, do we have a bug for further work on it?

Bug 349531 is where I'd like to clean up the way we populate breadcrumbs, set page "current location" etc. and make things more semantic.  But I think you should open a separate bug for having a readable user name in the profile, etc., and then we can decide if we want to use that in the breadcrumb root.
Comment 9 John Arthorne CLA 2011-10-27 15:53:35 EDT
*** Bug 357828 has been marked as a duplicate of this bug. ***