Bug 357741 - [gerrit] Change-Id in review editor attribute section links to commit
Summary: [gerrit] Change-Id in review editor attribute section links to commit
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Benjamin Muskalla CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-15 05:06 EDT by Sascha Scholz CLA
Modified: 2011-09-15 12:23 EDT (History)
2 users (show)

See Also:

Attachments
screenshot (2.85 KB, image/png)
2011-09-15 05:27 EDT, Sascha Scholz CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Scholz CLA 2011-09-15 05:06:15 EDT 
When clicking the Change-Id in the attibutes section of the review editor (e.g. I52b9db2d7ae31ff6ee2f91a1af39754f39acd6ba), Eclipse tries to open it as a commit.

Error message:

"The commit 52b9db2d7ae31ff6ee2f91a1af39754f39acd6ba was not found in any of the configured repositories"
Comment 1 Sascha Scholz CLA 2011-09-15 05:26:46 EDT 
I tried out some more things and noticed that the linking via Ixxxxxxx works only in the "Publish Comments..." dialog. It doesn't work at all in the Description, and in the Comments section it's broken (wrong pattern matches and it's again tried to open it as a commit, see screenshot).
Comment 2 Sascha Scholz CLA 2011-09-15 05:27:21 EDT 
Created attachment 203392 [details]
screenshot
Comment 3 Steffen Pingel CLA 2011-09-15 06:54:11 EDT 
The hyperlink detector is contributed by the EGit Mylyn bridge. I'm moving this bug since it should not recognize the Gerrit IDs as commit references.
Comment 4 Benjamin Muskalla CLA 2011-09-15 12:23:56 EDT 
Yep, will take this.