Comment 1 Andrew Eisenberg 2011-09-13 23:06:50 EDT

Looks like return type for the particular element was set to an invalid value.

Comment 2 Andrew Eisenberg 2011-09-15 13:45:10 EDT

The problem here is happening because IProgramElement.getCorrespondingType(false) is not returning the proper non-qualified type name.

I'll look deeper into this and find out exactly what it should be returning and how to make the change so that it does return the correct value.

Comment 3 Andrew Eisenberg 2011-09-15 13:56:06 EDT

In this particular case, IProgramElement.getCorrespondingType(true) will correctly return:

java.util.List<com.springsource.petclinic.domain.Vet>

However, the logic for getCorrespondingType just looks for the last '.' and removes everything before that to create the simple name, which is wrong when generics are involved.

The particular exception being found here occurs because IntertypeElement.getSignature() creates an unresolved type signature (ie- using simple names and beginning with 'Q').  The reason why we need to use an unresolved signature is that the signature generated must accurately reflect the source code (ie- if the source code uses simple names, then the signature must be unresolved).  

So, we must fix IProgramElement.getCorrespondingType(false).  It must return: List<Vet>.

Comment 4 Andrew Eisenberg 2011-09-15 17:50:25 EDT

Here is a simple method with some test cases that should be useful for solving the problem.  It can be used in ProgramElement.getCorrespondingType().

import junit.framework.TestCase;

public class Converter extends TestCase {

    String convert(String qualName) {
        char[] charArray = qualName.toCharArray();
        StringBuilder candidate = new StringBuilder(charArray.length);
        StringBuilder complete = new StringBuilder(charArray.length);
        for (char c : charArray) {
            switch (c) {
                case '.':
                    candidate.delete(0, candidate.length());
                    break;
                case '<':
                case ',':
                case '>':
                    complete.append(candidate).append(c);
                    candidate.delete(0, candidate.length());
                    break;
                default:
                    candidate.append(c);
            }
        }
        complete.append(candidate);
        return complete.toString();
    }
    
    
    public void testConvert1() throws Exception {
        assertEquals("AAA", convert("AAA"));
    }
    public void testConvert2() throws Exception {
        assertEquals("AAA", convert("a.b.c.AAA"));
    }
    public void testConvert2a() throws Exception {
        assertEquals("A", convert("aa.ba.ca.A"));
    }
    public void testConvert3() throws Exception {
        assertEquals("AAA<>", convert("a.b.c.AAA<>"));
    }
    public void testConvert4() throws Exception {
        assertEquals("AAA<A>", convert("a.b.c.AAA<A>"));
    }
    public void testConvert5() throws Exception {
        assertEquals("AAA<A>", convert("a.b.c.AAA<aa.A>"));
    }
    public void testConvert6() throws Exception {
        assertEquals("AAA<A,B>", convert("a.b.c.AAA<aa.A,bb.B>"));
    }
    public void testConvert7() throws Exception {
        assertEquals("AAA<A<B>>", convert("a.b.c.AAA<aa.A<bb.B>>"));
    }
    public void testConvert8() throws Exception {
        assertEquals("AAA<A<B>,AA<GG<KK>>>", convert("a.b.c.AAA<aa.A<bb.B>,a.b.c.AA<GG<KK>>>"));
    }
}

Comment 5 Andrew Clement 2011-09-15 21:00:39 EDT

fix is in.  I'll put an AspectJ into AJDT imminently to ensure we can get the fix into AJDT for STS 2.8.0.M2.