Bug 356924 - [UMLPropertiesView] Type editor in property pages not updated after undo/redo of type rename action
Summary: [UMLPropertiesView] Type editor in property pages not updated after undo/redo...
Status: NEW
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.10.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 364176 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-09-07 08:40 EDT by Alain Le Guennec CLA
Modified: 2017-09-08 09:48 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alain Le Guennec CLA 2011-09-07 08:40:00 EDT 
Assume you have a type and a typed element typed by that type.
Rename the type (using F2) to a new name.
Select the typed element and display its property page.
The type editor is displaying the new type name (OK).
Execute undo for the type rename action, without changing the selection.
Now the type editor is still displaying the new type name, not the old type name as it should, even though the name as been reverted.
Comment 1 Camille Letavernier CLA 2011-09-07 08:47:14 EDT 
This is a common problem in the whole property view framework : reference editors listen on the "type" property, not on the object's properties.

The reference itself doesn't change, so the widget is not refreshed.

The widgets should listen on their LabelProvider, and the LabelProvider should listen on the object's properties.

This will be done after SR1, at best, as LabelProviders need to be refactored anyway.
Comment 2 Camille Letavernier CLA 2013-07-05 12:51:44 EDT 
Still valid in 0.10.0

As LabelProviders are shared, we cannot dispose them. Thus, it would be really dangerous to use listeners (MemoryLeaks)
Comment 3 Benoit Maggi CLA 2014-09-15 09:28:04 EDT 
Same Problem as 364176
Comment 4 Camille Letavernier CLA 2014-09-15 09:29:36 EDT 
*** Bug 364176 has been marked as a duplicate of this bug. ***