Bug 35649 - The SourceMapper instances could share the fileNamefilter
Summary: The SourceMapper instances could share the fileNamefilter
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 trivial (vote)
Target Milestone: 2.1.1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-25 11:41 EST by Olivier Thomann CLA
Modified: 2003-06-10 10:25 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2003-03-25 11:41:31 EST 
Each constructor of the SourceMapper creates its own filenameFilter. They could 
be reused, because they are immutable. So only one filenameFilter could be 
shared among all source mappers.
Comment 1 Philipe Mulet CLA 2003-03-25 11:56:21 EST 
Not critical
Comment 2 Philipe Mulet CLA 2003-04-02 06:31:48 EST 
Reopen
Comment 3 Olivier Thomann CLA 2003-04-04 15:58:34 EST 
Define a new constant FileNameFilter and use it in each constructor. This 
prevents from creating unnecessary instances of filename filters.
Comment 4 Olivier Thomann CLA 2003-04-14 12:09:29 EDT 
Backported to 2.1 maintenance stream.
Comment 5 Jerome Lanneluc CLA 2003-04-15 10:46:16 EDT 
Fixed in 2.2 stream as well.
Comment 6 David Audel CLA 2003-06-02 09:28:37 EDT 
Verified.
Comment 7 David Audel CLA 2003-06-10 10:25:21 EDT 
Verified for 3.0M1.