Bug 356191 - Patch for enhancement request
Summary: Patch for enhancement request
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.4.0   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-30 08:49 EDT by Frederic Leger CLA
Modified: 2013-06-05 05:54 EDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (5.52 KB, application/octet-stream)
2011-08-30 08:49 EDT, Frederic Leger CLA 		eugene: iplog-
Details
Fixed the Makefile.inc version I started from ... (5.52 KB, patch)
2011-08-30 11:09 EDT, Frederic Leger CLA 		eugene: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Leger CLA 2011-08-30 08:49:17 EDT 
Created attachment 202414 [details]
Proposed patch

The agent Makefile and Makefile.inc are GNU-only oriented. I propose a patch to make it possible for the Talos project to build the agent with MSVC from the command line.

I had to move the link steps commands from $(CC) to $(LINK) because it is actually a link. I could not use LD since the cygwin build seem to automatically define LD to ld

I tried to do fewest possible changes to the file, but still I am used to Foundation/DFW development so I may have done useless things ...
Comment 1 Frederic Leger CLA 2011-08-30 11:09:31 EDT 
Created attachment 202429 [details]
Fixed the Makefile.inc version I started from ...

The previous patch file was wrong regarding the Makefile.inc version. This should apply to the 0.4.0 branch, sorry ...
Comment 2 Eugene Tarassov CLA 2011-08-31 14:45:55 EDT 
I have committed the patch.
Thanks!
Comment 3 Frederic Leger CLA 2011-08-31 15:06:17 EDT 
Thanks a lot Eugene !