Bug 3557 - TP125: browse for enclosing class does nothing (1G842I9)
Summary: TP125: browse for enclosing class does nothing (1G842I9)
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All Windows NT
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Martin Aeschlimann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 22:57 EDT by Erich Gamma CLA
Modified: 2002-02-13 09:09 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erich Gamma CLA 2001-10-10 22:57:05 EDT 
TM (25.01.2001 15:24:30)
	ITPJUI 72.02 dm

	1) create a project with an empty source folder
	2) select the empty source folder and open the create class wizard
	3) press the "Browse" button on the enclosing class field.
	4) observe: nothing happens

	There's nothing to show, since the source folder is empty, but I think not doing anything is 
	a bad option. I'd rather see an empty dialog.

EG (2/1/01 10:07:21 AM)
	can't we just disable the "Browse" button.

MA (2/12/01 4:52:40 PM)
	I think the problem lies in the TypeSelectionDialog. It should show an empty dialog
Comment 1 Martin Aeschlimann CLA 2001-10-16 11:16:17 EDT 
moved to 'active'
Comment 2 Martin Aeschlimann CLA 2001-10-22 10:19:05 EDT 
Thisis fixed in 205. A message dialog is shown.
Comment 3 Andre Weinand CLA 2002-01-17 03:46:48 EST 
Now, the browse button opens a dialog, and the dialog shows also binary 
classes, e.g. all classes in JDK, which actually cannot be used as eclosing 
class.
In general this gives us a huge list of classes, of which only a small subset 
is actually of interest.
Comment 4 Martin Aeschlimann CLA 2002-01-17 05:27:07 EST 
changed so that the dialog only shows types from source.
>20116
Comment 5 Martin Aeschlimann CLA 2002-01-23 12:00:19 EST 
Verified. >20122. JRT.
Comment 6 Martin Aeschlimann CLA 2002-01-23 12:15:42 EST 
After some consideration I've decided that the behaviour of this dialogue is 
quite strange. By showing types from the sources allows the creation of an 
inner class in a class that is outside the selected source folder. Why would 
anybody want to do that? A better solution would be to show an empty dialogue.
>20122. JRT.
Comment 7 Martin Aeschlimann CLA 2002-01-24 07:33:28 EST 
now only types from the given source folder are available in the selection 
dialog. the user still can name a type from another source folder, a warning is 
issued then. > 20124
Comment 8 Martin Aeschlimann CLA 2002-02-13 09:09:29 EST 
A dialog now appears with the message 'No types available'. Good. Verified. -
>20020205. JRT.