Bug 353147 - Memory Leak: Actions holding editor selection references after edtior closes
Summary: Memory Leak: Actions holding editor selection references after edtior closes
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-26 14:19 EDT by Thomas Fletcher CLA
Modified: 2011-08-16 07:39 EDT (History)
3 users (show)

See Also:

Attachments
YourKit memory reference screenshot (337.34 KB, image/png)
2011-07-26 14:20 EDT, Thomas Fletcher CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Fletcher CLA 2011-07-26 14:19:45 EDT 
Doing some memory leak profiling on our application that has a custom editor, we have found that a git action is not properly clearing its selection after an editor is closed.

Profiled using YourKit profiler (www.yourkit.com)
* Open an editor
* Close an editor
- Run the GC and take a memory snapshot and there are still references held by the git actions:
Comment 1 Thomas Fletcher CLA 2011-07-26 14:20:43 EDT 
Created attachment 200387 [details]
YourKit memory reference screenshot

Attached a screenshot of the result in YourKit.
Comment 2 Remy Suen CLA 2011-07-27 10:00:35 EDT 
Also see bug 352282 and bug 352743.
Comment 3 Remy Suen CLA 2011-08-16 07:39:12 EDT 
Looking at the code, I would expect the leak to be constant, where the number of leaked editors is always one (or perhaps one per workbench window). Is this correct?