Bug 352826 - Use size property to compute value string
Summary: Use size property to compute value string
Status: RESOLVED FIXED
Alias: None
Product: DLTK
Classification: Technology
Component: Common-Debug (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: dltk.common-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks: 365334
  Show dependency tree
 
Reported: 2011-07-22 04:02 EDT by Julien Desgats CLA
Modified: 2011-12-01 11:35 EST (History)
3 users (show)

See Also:

Attachments
Use IIndexedValue.getSize() when possible to get size (1.35 KB, patch)
2011-07-22 04:02 EDT, Julien Desgats CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Desgats CLA 2011-07-22 04:02:26 EDT 
Created attachment 200154 [details]
Use IIndexedValue.getSize() when possible to get size

Currently, the org.eclipse.dltk.debug.core.model.CollectionScriptType.formatValue use IScriptValue.getVariables().length to get the children count. This can lead to useless property_get commands in case of the children of the value has not been retrieved yet.

The proposed patch use IIndexedValue.getSize() (which is a basic getter) if possible.
Comment 1 Benjamin Cabé CLA 2011-12-01 11:12:37 EST 
Ping :)
Any chance you guys could review and include the attached patch?
Comment 2 Andrey Platov CLA 2011-12-01 11:21:00 EST 
Pong :) 
Reviewing...
Comment 3 Andrei Sobolev CLA 2011-12-01 11:28:19 EST 
Patch are applied to HEAD.
Thanks.