Bug 352696 - [Tests] Cleanup RepositoryConfigs
Summary: [Tests] Cleanup RepositoryConfigs
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Eike Stepper CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2011-07-21 01:31 EDT by Eike Stepper CLA
Modified: 2012-09-21 07:18 EDT (History)
0 users

See Also:


Attachments
Patch v1 - for future reference (167.17 KB, patch)
2011-07-21 01:35 EDT, Eike Stepper CLA
no flags Details | Diff
Additional Patch (7.30 KB, patch)
2011-07-27 02:56 EDT, Eike Stepper CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Stepper CLA 2011-07-21 01:31:32 EDT
The subclasses of RepositoryConfig are often polluted with configuration items that belong on the repository level and not on the store level, e.g. auditing and branching modes and ID generation location. This leads to subclass explosion and poor reuse.

Move the generic repository configurations up into RepositoryConfig.
Comment 1 Eike Stepper CLA 2011-07-21 01:35:03 EDT
Created attachment 200051 [details]
Patch v1 - for future reference
Comment 2 Eike Stepper CLA 2011-07-21 01:36:15 EDT
Committed revision 8726:
- trunk/plugins/org.eclipse.emf.cdo.common
- trunk/plugins/org.eclipse.emf.cdo.dawn.tests
- trunk/plugins/org.eclipse.emf.cdo.server.db
- trunk/plugins/org.eclipse.emf.cdo.tests
- trunk/plugins/org.eclipse.emf.cdo.tests.db
- trunk/plugins/org.eclipse.emf.cdo.tests.db4o
- trunk/plugins/org.eclipse.emf.cdo.tests.hibernate
- trunk/plugins/org.eclipse.emf.cdo.tests.mongodb
- trunk/plugins/org.eclipse.emf.cdo.tests.objectivity
- trunk/plugins/org.eclipse.emf.cdo.tests.ui
Comment 3 Eike Stepper CLA 2011-07-21 01:46:49 EDT
Committed revision 8727:
- trunk/plugins/org.eclipse.emf.cdo.tests
- trunk/plugins/org.eclipse.emf.cdo.tests.db
Comment 4 Eike Stepper CLA 2011-07-21 01:47:11 EDT
Resolved
Comment 5 Eike Stepper CLA 2011-07-27 02:55:23 EDT
Offline tests are broken
Comment 6 Eike Stepper CLA 2011-07-27 02:56:27 EDT
Created attachment 200418 [details]
Additional Patch
Comment 7 Eike Stepper CLA 2011-07-27 02:58:24 EDT
Committed revision 8822:
- trunk/plugins/org.eclipse.emf.cdo.tests
- trunk/plugins/org.eclipse.emf.cdo.tests.db
Comment 8 Eike Stepper CLA 2011-07-27 02:58:40 EDT
Fixed.
Comment 9 Eike Stepper CLA 2012-09-21 07:18:06 EDT
Closing.