Bug 351964 - [performance] Remove unnecessary change to CompletionEngine#acceptBindings
Summary: [performance] Remove unnecessary change to CompletionEngine#acceptBindings
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.2.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.2.5   Edit
Assignee: Ian Tewksbury CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2011-07-13 08:58 EDT by Ian Tewksbury CLA
Modified: 2011-09-23 11:42 EDT (History)
1 user (show)

See Also:
cmjaun: review+
thatnitind: review+

Attachments
Fix patch (10.30 KB, patch)
2011-07-13 08:59 EDT, Ian Tewksbury CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Tewksbury CLA 2011-07-13 08:58:04 EDT 
When bug 306958 went in a change to CompletionEngine#acceptBindings left over from one of the previous iterations of the patch made its way into the final patch.  This change should be reverted because it is unnecessary.
Comment 1 Ian Tewksbury CLA 2011-07-13 08:59:06 EDT 
Created attachment 199577 [details]
Fix patch

Patch to remove unnecessary change.
Comment 2 Nitin Dahyabhai CLA 2011-07-13 19:34:02 EDT 
Released to 3.2 maintenance.  Not needed in HEAD.