Bug 351962 - [performance] Revert unnecessary changes to MethodScope#createMethod
Summary: [performance] Revert unnecessary changes to MethodScope#createMethod
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.2.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.2.5   Edit
Assignee: Ian Tewksbury CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2011-07-13 08:42 EDT by Ian Tewksbury CLA
Modified: 2011-09-23 11:42 EDT (History)
1 user (show)

See Also:
cmjaun: review+
thatnitind: review+

Attachments
Fix Patch (3.98 KB, patch)
2011-07-13 08:44 EDT, Ian Tewksbury CLA 		no flags Details | Diff
Updated patch (6.12 KB, patch)
2011-07-13 11:51 EDT, Chris Jaun CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Tewksbury CLA 2011-07-13 08:42:35 EDT 
Bug 306958 made unnecessary changes to MethodScope#createMethod.  These changes were not only not necessary but also cause a performance regression.  These changes should be backed out.
Comment 1 Ian Tewksbury CLA 2011-07-13 08:44:47 EDT 
Created attachment 199574 [details]
Fix Patch

Backs out the changes to MethodScope#createMethod done by bug 306958.

All existing JUnits still pass even after reverting these changes.  Including all of the new content assist tests provided in bug 306958.
Comment 2 Chris Jaun CLA 2011-07-13 11:51:22 EDT 
Created attachment 199604 [details]
Updated patch

The previous patch was not sufficient to solve the performance problem.
Comment 3 Nitin Dahyabhai CLA 2011-07-13 16:17:10 EDT 
Applied to R3_2_maintenance.
Comment 4 Nitin Dahyabhai CLA 2011-07-14 01:44:48 EDT 
Done