Bug 351864 - [1.7][templates] Add 'try-with-resource' template
Summary: [1.7][templates] Add 'try-with-resource' template
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 95787
Blocks:
  Show dependency tree
 
Reported: 2011-07-12 11:29 EDT by Dani Megert CLA
Modified: 2015-10-27 10:29 EDT (History)
4 users (show)

See Also:


Attachments
Added the template for try-with-resources (2.96 KB, patch)
2012-11-13 22:13 EST, Jordan Chin CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-07-12 11:29:57 EDT
We should add a 'try-with-resource' template
Comment 1 Jordan Chin CLA 2012-11-13 22:13:08 EST
Created attachment 223546 [details]
Added the template for try-with-resources
Comment 2 Deepak Azad CLA 2012-11-14 03:31:14 EST
The patch works, but I now realize that maybe we should fix this only after bug 95787 is fixed.
Comment 3 Dani Megert CLA 2012-11-14 04:33:41 EST
(In reply to comment #2)
> The patch works, but I now realize that maybe we should fix this only after
> bug 95787 is fixed.

Definitely.
Comment 4 Lars Vogel CLA 2015-10-05 19:11:15 EDT
(In reply to Dani Megert from comment #3)
> (In reply to comment #2)
> > The patch works, but I now realize that maybe we should fix this only after
> > bug 95787 is fixed.
> 
> Definitely.

Java 7 is out of maintenance, are you OK in adding this template?
Comment 5 Dani Megert CLA 2015-10-27 10:29:41 EDT
(In reply to Lars Vogel from comment #4)
> (In reply to Dani Megert from comment #3)
> > (In reply to comment #2)
> > > The patch works, but I now realize that maybe we should fix this only after
> > > bug 95787 is fixed.
> > 
> > Definitely.
> 
> Java 7 is out of maintenance, are you OK in adding this template?

No. Lots of people will leave their code base as is or have no choice when doing maintenance, e.g. 4.5.2 work. They would get upset if they get wrong templates (see 95787 and its duplicates).

Help is appreciated for bug 95787.


Jordan, if you are still around, can you please sign the CLA.