Comment 1 Jerome Lanneluc 2003-03-17 07:18:08 EST

Proposed fix on PackageFragmentRoot:
- Add constant: protected final static String NO_SOURCE_ATTACHEMENT = ""; //
$NON-NLS-1$
- Change getSourceAttachmentProperty() to:
/**
 * Returns the server property for this package fragment root's
 * source attachement.
 */
protected String getSourceAttachmentProperty() throws JavaModelException {
	String propertyString = null;
	QualifiedName qName= getSourceAttachmentPropertyName();
	try {
		propertyString = ResourcesPlugin.getWorkspace().getRoot
().getPersistentProperty(qName);
		
		// if no existing source attachment information, then lookup a 
recommendation from classpath entries
		if (propertyString == null) {
			IClasspathEntry recommendation = 
findSourceAttachmentRecommendation();
			if (recommendation != null) {
				IPath rootPath = 
recommendation.getSourceAttachmentRootPath();
				propertyString = 
					recommendation.getSourceAttachmentPath
().toString() 
						+ ((rootPath == null) 
							? "" : //$NON-NLS-1$
						
	(ATTACHMENT_PROPERTY_DELIMITER + rootPath.toString())); 
				setSourceAttachmentProperty(propertyString);
			} else {
				// mark as being already looked up
				setSourceAttachmentProperty
(NO_SOURCE_ATTACHEMENT);
			}
		} else if (NO_SOURCE_ATTACHEMENT.equals(propertyString)) {
			// already looked up and no source attachment found
			return null;
		}
		return propertyString;
	} catch (CoreException ce) {
		throw new JavaModelException(ce);
	}
}

Comment 2 Philipe Mulet 2003-03-17 07:34:52 EST

Nice simple optimization fix for a performance release... 
Would like to get approval for RC3.

Comment 3 Olivier Thomann 2003-03-17 08:46:30 EST

NO_SOURCE_ATTACHEMENT could be used instead of "" in the code:
propertyString = 
recommendation.getSourceAttachmentPath
().toString() 
	+ ((rootPath == null) 
		? "" : //$NON-NLS-1$
...

Would you have a test case that would allow me to check that this change
improves the performance.

Comment 4 Jerome Lanneluc 2003-03-17 09:02:01 EST

You can use the test case described in bug 34008.

Comment 5 Philipe Mulet 2003-03-18 04:42:58 EST

Got approval for RC3

Comment 6 Jerome Lanneluc 2003-03-18 05:03:20 EST

Fix released to HEAD.

Comment 7 David Audel 2003-03-20 06:56:29 EST

Verified.