35130 – Dialogs do not set the dialog font

Bug 35130 - Dialogs do not set the dialog font

Summary: Dialogs do not set the dialog font

Status:	RESOLVED FIXED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	2.1
Hardware:	PC Windows 2000

Importance:	P3 normal (vote)
Target Milestone:	2.1 RC3
Assignee:	Dirk Baeumer
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2003-03-17 06:56 EST by Erich Gamma
Modified:	2003-03-21 13:11 EST (History)
CC List:	1 user (show)

See Also:

Attachments
Compare Patches (6.94 KB, patch) 2003-03-17 16:42 EST, Dirk Baeumer	no flags	Details \| Diff
JUnit patches (7.91 KB, patch) 2003-03-17 16:43 EST, Dirk Baeumer	no flags	Details \| Diff
JDT/UI patches (104.63 KB, patch) 2003-03-17 16:44 EST, Dirk Baeumer	no flags	Details \| Diff
Search Patches (6.32 KB, patch) 2003-03-17 16:46 EST, Dirk Baeumer	no flags	Details \| Diff
UI Editor patches (988 bytes, patch) 2003-03-17 16:48 EST, Dirk Baeumer	no flags	Details \| Diff
Text Editor Patches (688 bytes, patch) 2003-03-17 16:50 EST, Dirk Baeumer	no flags	Details \| Diff
Released JDT/UI patches (103.30 KB, patch) 2003-03-18 13:14 EST, Dirk Baeumer	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Erich Gamma

2003-03-17 06:56:59 EST

The platform supports the concept of a dialog font. Most plug-ins have migrated 
to this new support and JDT UI (search, compare, junit) now looks inconsistent.

We should fix this inconsistency.

Fix approved by Kai.

Comment 1 Dirk Baeumer

2003-03-17 16:42:42 EST

Created attachment 4187 [details]
Compare Patches

Comment 2 Dirk Baeumer

2003-03-17 16:43:26 EST

Created attachment 4188 [details]
JUnit patches

Comment 3 Dirk Baeumer

2003-03-17 16:44:21 EST

Created attachment 4189 [details]
JDT/UI patches

Comment 4 Dirk Baeumer

2003-03-17 16:46:22 EST

Created attachment 4190 [details]
Search Patches

Comment 5 Dirk Baeumer

2003-03-17 16:48:22 EST

Created attachment 4191 [details]
UI Editor patches

Comment 6 Dirk Baeumer

2003-03-17 16:50:21 EST

Created attachment 4192 [details]
Text Editor Patches

Comment 7 Dirk Baeumer

2003-03-18 13:14:21 EST

Created attachment 4213 [details]
Released JDT/UI patches

Comment 8 Dirk Baeumer

2003-03-18 13:16:12 EST

Comments from Martin Aeschlimann:

Reviewed, seems to be ok.

NewTypeWizardPage: remove the change, only a (unneeded) import was added
SourceAttachmentPropertyPage: 1 case is missed (line 73)
SourceAttachmentBlock & NameConventionConfigurationBlock: No changes needed as 
the containers of the blocks already set the font

Comment 9 Dirk Baeumer

2003-03-18 13:17:25 EST

Comments are correct except for NameConventionConfigurationBlock. The change 
is the nested class NameConventionInputDialog, which is a dialog.

Comment 10 Dirk Baeumer

2003-03-18 13:23:52 EST

Fixes released for JDT/UI. Reviewed by Martin Aeschlimann.

Comment 11 Dirk Baeumer

2003-03-18 13:26:01 EST

Fixes released for org.eclipse.search. Reviewed by Martin Aeschlimann.

Comment 12 Dirk Baeumer

2003-03-18 13:31:25 EST

Kai, can you please release the changes for org.eclipse.ui.editors (patch UI 
Editors) and org.eclipse.ui.workbench.texteditor (patch Text Editor).

Erich, can you please release the change for org.eclipse.compare (patch 
Compare) and org.eclipse.jdt.junit (patch JUnit).

I don't have commit rights.

Comment 13 Dirk Baeumer

2003-03-18 14:09:40 EST

Attached patches are still valid. No conflicts with current repository content.

Comment 14 Kai-Uwe Maetzel

2003-03-18 14:14:58 EST

Done for Text.

Comment 15 Erich Gamma

2003-03-18 14:45:14 EST

done for jdt.junit

Comment 16 Erich Gamma

2003-03-18 14:48:46 EST

done for compare

all patches got released - closing bug

Comment 17 Adam Kiezun

2003-03-20 12:37:03 EST

bad font in Override/implement 'group methods by types'

Comment 18 Adam Kiezun

2003-03-20 12:44:54 EST

other bad ones i found so far:
- pde plugin search (most controls are bad)
- java debug pref page
- installed jre pref page
- compare with local history

Comment 19 Andre Weinand

2003-03-21 11:42:48 EST

- compare with local history is OK in RC3a

Comment 20 Andre Weinand

2003-03-21 13:11:20 EST

Problems on MacOS X:
- dialog fonts are not propagated into
         TabFolders
         Text fields
- "Java Element Filters" dialog (strange because it doesn't use TabFolders)
- Install/Update pref page: Proxy Settings group
- Java pref page: all groups are wrong (strange, because other groups seem to work)
- Javadoc pref page