Bug 351106 - CVS actions trigger EGIT Pass Phrase pop-up
Summary: CVS actions trigger EGIT Pass Phrase pop-up
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-04 12:46 EDT by Ed Willink CLA
Modified: 2011-09-04 09:07 EDT (History)
1 user (show)

See Also:


Attachments
VisualVM Thread Dump (19.60 KB, text/plain)
2011-09-04 02:03 EDT, Ed Willink CLA
no flags Details
Screenshot depicting the state in question. (75.24 KB, image/png)
2011-09-04 07:00 EDT, Remy Suen CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2011-07-04 12:46:23 EDT
With both CVS and EGit 'in use', invoking a CVS action such as replace from head causes the Egit Pass Phrase pop-up to appear even though Egit is not required forb the operation.
Comment 1 Remy Suen CLA 2011-07-06 09:18:15 EDT
Please get a thread dump when this error occurs so we know what piece of code is opening the dialog.
http://wiki.eclipse.org/index.php/How_to_report_a_deadlock
Comment 2 Ed Willink CLA 2011-07-07 03:42:55 EDT
(In reply to comment #1)
> Please get a thread dump when this error occurs so we know what piece of code
> is opening the dialog.
> http://wiki.eclipse.org/index.php/How_to_report_a_deadlock

This doesn't work. eclipsec.exe gives a console but Ctrl+Break just closes it.

The repro is trivial.

With EGIT and CVS repositories.

In the CVS Repositories View, browse to display contents of HEAD on e.g. :extssh:ewillink@dev.eclipse.org:/cvsroot/modeling and the popup appears.
Comment 3 Remy Suen CLA 2011-09-03 14:37:29 EDT
(In reply to comment #2)
> In the CVS Repositories View, browse to display contents of HEAD on e.g.
> :extssh:ewillink@dev.eclipse.org:/cvsroot/modeling and the popup appears.

I cannot get this to happen. Can you get a thread dump with VisualVM?
Comment 4 Ed Willink CLA 2011-09-04 02:03:53 EDT
Created attachment 202713 [details]
VisualVM Thread Dump

It needs to be an extssh rather than pserver CVS connection to reproduce.

Full thread dump attached.

Offending thread seems to be:

"Worker-0" prio=6 tid=0x53e10c00 nid=0x998 in Object.wait() [0x542df000]
   java.lang.Thread.State: TIMED_WAITING (on object monitor)
	at java.lang.Object.wait(Native Method)
	- waiting on <0x0547df10> (a org.eclipse.ui.internal.Semaphore)
	at org.eclipse.ui.internal.Semaphore.acquire(Semaphore.java:43)
	- locked <0x0547df10> (a org.eclipse.ui.internal.Semaphore)
	at org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:168)
	at org.eclipse.swt.widgets.Display.syncExec(Display.java:4683)
	at org.eclipse.jsch.internal.ui.authenticator.WorkbenchUserAuthenticator.promptForUserInfo(WorkbenchUserAuthenticator.java:55)
	at org.eclipse.jsch.internal.core.UserInfoImpl.promptSecret(UserInfoImpl.java:86)
	at org.eclipse.jsch.internal.core.UserInfoImpl.promptPassphrase(UserInfoImpl.java:98)
	at com.jcraft.jsch.UserAuthPublicKey.start(UserAuthPublicKey.java:120)
	- locked <0x05706ea8> (a java.util.Vector)
	at com.jcraft.jsch.Session.connect(Session.java:419)
	at com.jcraft.jsch.Session.connect(Session.java:150)
	at org.eclipse.jsch.internal.core.JSchProvider.connect(JSchProvider.java:87)
	at org.eclipse.team.internal.ccvs.ssh2.JSchSession.createSession(JSchSession.java:112)
	at org.eclipse.team.internal.ccvs.ssh2.JSchSession.getSession(JSchSession.java:83)
	at org.eclipse.team.internal.ccvs.ssh2.CVSSSH2ServerConnection.internalOpen(CVSSSH2ServerConnection.java:134)
	at org.eclipse.team.internal.ccvs.ssh2.CVSSSH2ServerConnection.open(CVSSSH2ServerConnection.java:119)
Comment 5 Remy Suen CLA 2011-09-04 07:00:48 EDT
Created attachment 202717 [details]
Screenshot depicting the state in question.

(In reply to comment #4)
> It needs to be an extssh rather than pserver CVS connection to reproduce.

I don't see a problem here. I get prompted for my password for connecting to a CVS repository through extssh, as I expect to.
Comment 6 Ed Willink CLA 2011-09-04 09:07:08 EDT
My extssh password is in 'secure' storage, so I only get extssh prompts at the six monthly password update intervals.

Instead I get the GIT pass-phrase prompt.