Bug 350881 - [explorer] Prevent tendency to start JSDT from navigator contribution when not really needed
Summary: [explorer] Prevent tendency to start JSDT from navigator contribution when no...
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.2.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.2.5   Edit
Assignee: Ian Tewksbury CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard: WI77228
Keywords:
Depends on:
Blocks: 374746
  Show dependency tree
 
Reported: 2011-06-30 16:25 EDT by Ian Tewksbury CLA
Modified: 2012-04-03 06:00 EDT (History)
3 users (show)

See Also:
thatnitind: review+

Attachments
Fix patch (11.63 KB, patch)
2011-06-30 16:26 EDT, Ian Tewksbury CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Tewksbury CLA 2011-06-30 16:25:27 EDT 
The current enablement triggers for the navigator contributions of JSDT are to broad and cause JSDT to start up as soon as any project is added to the workspace.  They should be narrowed so JSDT only starts up if a project with the JS nature is added to the workspace.
Comment 1 Ian Tewksbury CLA 2011-06-30 16:26:54 EDT 
Created attachment 198934 [details]
Fix patch

This patch narrows the enablement expression for the navigator contributions of JSDT.

I have tested all of the navigator contributions for JSDT that I know of and they work as I expect them too.
Comment 2 Nitin Dahyabhai CLA 2011-07-14 16:25:46 EDT 
Applied to 3.2.5 and HEAD.
Comment 3 Martin Oberhuber CLA 2011-07-21 07:51:37 EDT 
We would like to pick up this fix from the 3.3.1 Stream, but for now there's no build: http://download.eclipse.org/webtools/downloads/

Hudson builds have been failing since > 1 week, last stable build > 1 month ago:
https://hudson.eclipse.org/hudson/job/cbi-wtp-wst.jsdt/

Does anybody know when a first 3.3.1 build would be available ?
Comment 4 Martin Oberhuber CLA 2011-09-07 05:49:35 EDT 
Can I assume that this is in recent 3.3.1 builds, eg
http://download.eclipse.org/webtools/downloads/drops/R3.3.1/M-3.3.1-20110906122954

Does 3.3.1 build off HEAD?