Community
Participate
Working Groups
Build Identifier: I20110613-1736 The JAR specification dictates that a manifest must end with a line break, and the PDE builder enforces this with the 'Header must be terminated by a line break' marker. I recently helped a colleague trying to understand why a manifest was invalid. Initially it didn't end with a line break, so following the message, he pressed Enter. However, the previous line was a continuation, so the new line actually contained a single (inconspicuous) space, resulting in the same message, and much confusion as to whether the builder had broken. :) This patch adds a quick fix resolution to the marker. If the manifest ends with a content line, it adds a newline. If it ends with a line containing only whitespace, it deletes the whitespace, leaving just the newline. Reproducible: Always
You haven't attached the patch :)
Created attachment 198869 [details] Patch to add quick fix I've attached the patch to the bug report.
Hi Benjamin - oops! I wasn't such a quick response though! :D
Patch looks promising. I will give it a proper review in early 3.8.
FYI Benjamin, we've started using the [patch] tag for bugzillas with patches waiting for review. Helps clarify how much work is actually pending for a given set of bugs (There are already 59 bugs for 3.8, but a good number have fixes waiting for review).
Created attachment 201279 [details] Improved patch Fixes copyrights, replaces string attributes with constants, improves wording of the resolutions.
Fixed in HEAD.
Verified in I20110913-0200