Bug 350255 - [site] Problem with sites and Orion running over https
Summary: [site] Problem with sites and Orion running over https
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-24 09:29 EDT by Szymon Brandys CLA
Modified: 2011-09-01 11:42 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2011-06-24 09:29:32 EDT
Steps:
1) Configure Orion according to http://wiki.eclipse.org/Orion/Server_admin_guide#Configuring_to_run_over_SSL, do not modify jetty.http.port though, leave 8080
2) Create a project and add a site for it
3) Start the site

See that site is started on port 8080 and we cannot access it. The workaround is to update jetty.http.port as described in the admin guide.

I think that HostingActivator#registerHostingService should initialize the port using our configuration, not directly using the system property. Moreover I noticed a hardcoded protocol name "http" in SiteConfigurationResourceHandler#changeHostingStatus.

There is also an issue when Orion is started on the default http or https port (80 or 443). When a site is started, I can't access it by simply clicking the site link. But maybe it is  just a matter of Orion configuration.

Anyway there is a workaround to run Orion on https and have the site feture still working. So I think this is a 0.3 work item.
Comment 1 Mark Macdonald CLA 2011-06-28 15:20:21 EDT
http://git.eclipse.org/c/e4/org.eclipse.orion.server.git/commit/?id=e312099fee65b361b7170b00f2fcd57a9fd33e44

Removed the concept of a port number from the site hosting code. The original intent was to be able to host sites on a port that was different from the port that the rest of Orion was using. This made the code more complex and it was never used anyway.

Hosted sites now work with https. The workaround of setting jetty.http.port is not necessary. The hardcoded "http" prefix (which was only used for setting the X-Edit-Server header) is also removed.
Comment 2 Szymon Brandys CLA 2011-06-29 06:12:23 EDT
I also removed the note about the workaround from http://wiki.eclipse.org/Orion/Server_admin_guide#Configuring_to_run_over_SSL