Bug 349560 - Fetch from upstream not available when multiple repositories are selected
Summary: Fetch from upstream not available when multiple repositories are selected
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 enhancement with 5 votes (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
: 487609 (view as bug list)
Depends on:
Blocks: 358616
  Show dependency tree
 
Reported: 2011-06-16 09:30 EDT by Jan Lohre CLA
Modified: 2020-10-02 11:30 EDT (History)
12 users (show)

See Also:


Attachments
Possible patch for 349560 (3.07 KB, patch)
2015-03-05 08:13 EST, Ulrich Wielant CLA
no flags Details | Diff
Pull multiple repositories report (25.03 KB, image/png)
2018-09-04 10:24 EDT, Dmitry Katsubo CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Lohre CLA 2011-06-16 09:30:19 EDT
I guess the Summary sais it all.

If I select multiple repositories there is no context menu action to fetch from the remote repository. 

However there is a pull action, and as pull is fetch + merge it should be possible and easy to implement it for fetch only.

I would be willing to make a contribution here if you were able to give me a pointer where I should look.

Actually I have a version 1.1.x from the nightly update site.
Comment 1 Matthias Sohn CLA 2011-06-30 10:21:51 EDT
Look at egit commit 4197370f which implemented pull for multiple repositories and enhance FetchConfiguredRemoteCommand in a similar way (assuming you want to allow use of "Fetch from Upstream" with multi-selection).
Comment 2 Dani Megert CLA 2011-09-28 04:33:21 EDT
+1 to fix that. As a data point: the source on which I'm working is distributed over 15 repositories. Doing the fetch 15 times is just a waste of time for me.

>Look at egit commit 4197370f which implemented pull for multiple repositories
I don't see 'Pull' being enabled when multiple repositories are selected in the 'Git Repositories' view. This is with 1.1.0.201109151100-r.
Comment 3 Remy Suen CLA 2011-09-28 19:37:32 EDT
(In reply to comment #2)
> >Look at egit commit 4197370f which implemented pull for multiple repositories
> I don't see 'Pull' being enabled when multiple repositories are selected in the
> 'Git Repositories' view.

I can confirm this on 1.2.0.201109281613.

'Team > Pull' _is_ however enabled when two projects of differing parent repositories is selected in the 'Package Explorer' though. That seems to be what 4197370f was about.
Comment 4 Missing name CLA 2014-08-14 07:48:34 EDT
Adding Fetch from Upstream would be much better since Fetch doesnt touch local branches, Pull does, so fetch is much safer to use when working with more than one repo.
Comment 5 Ulrich Wielant CLA 2015-03-05 08:13:20 EST
Created attachment 251325 [details]
Possible patch for 349560

The patch is a first try to fix that problem. I wasn't able to test it because I failed to create a working test environment using description on the contributors guide (https://wiki.eclipse.org/EGit/Contributor_Guide).

I tried to apply the modification based on commit 4197370f09f23e4930ac80a045097cbd4946ea8e that implemented the changes for pull.

Please check and commit if it is ok.
Comment 6 Andrey Loskutov CLA 2015-03-05 08:18:10 EST
(In reply to Ulrich Wielant from comment #5)
> Created attachment 251325 [details]
> Possible patch for 349560
> 
> The patch is a first try to fix that problem. I wasn't able to test it
> because I failed to create a working test environment using description on
> the contributors guide (https://wiki.eclipse.org/EGit/Contributor_Guide).

Please if you think this is a problem which can affect other contributors, change the wiki accordingly or if you are not sure, open a bug with steps to reproduce.

> I tried to apply the modification based on commit
> 4197370f09f23e4930ac80a045097cbd4946ea8e that implemented the changes for
> pull.
> 
> Please check and commit if it is ok.

Can you please prepare Gerrit patch (you need to sign CLA) or is this the point where you've given up with the environment?
Comment 7 Andrey Loskutov CLA 2015-03-05 08:24:32 EST
(In reply to Ulrich Wielant from comment #5)
> Created attachment 251325 [details]
> Possible patch for 349560
> 
> The patch is a first try to fix that problem. 

Not sure if (as user) I would like multiple wizards opening one after each other, if I just want to "Fetch from Upstream"... Why do we need a wizard for "fetch from upstream", in case the "upstream" is configured? If it is not configured I would expect the menu will not be enabled, and "Fetch from..." should be used, but it is a different use case.
Comment 8 Ulrich Wielant CLA 2015-03-05 08:42:46 EST
I agree, but at the moment I just want to initiate fixing this bug. 

I managed to sign the CLA. I was not able to have a working eclipse environment so that all egit and jgit sources compile without problems.

How can I continue to provide a solution to this problem?
Comment 9 Andrey Loskutov CLA 2015-03-05 10:46:10 EST
(In reply to Ulrich Wielant from comment #8)
> I agree, but at the moment I just want to initiate fixing this bug. 
> 
> I managed to sign the CLA. I was not able to have a working eclipse
> environment so that all egit and jgit sources compile without problems.
> 
> How can I continue to provide a solution to this problem?

As said, if there is something we can make better for first time contributors, we should do it, but we must know *what* is not working for you. So far I haven't heard anything *concrete* :-)

BTW I would like to move the "environment" discussion to the mailing list:
https://dev.eclipse.org/mailman/listinfo/egit-dev
or better to the forum:
https://www.eclipse.org/forums/eclipse.egit
Comment 10 Bernd Eckenfels CLA 2016-08-30 13:32:57 EDT
*** Bug 487609 has been marked as a duplicate of this bug. ***
Comment 11 Bernd Eckenfels CLA 2016-08-30 13:34:55 EDT
(In reply to Andrey Loskutov - on the beach till 12.09 from comment #7)
> Not sure if (as user) I would like multiple wizards opening one after each
> other, if I just want to "Fetch from Upstream"... Why do we need a wizard
> for "fetch from upstream", in case the "upstream" is configured? If it is
> not configured I would expect the menu will not be enabled, and "Fetch
> from..." should be used, but it is a different use case.

You could even "fetch from all remotes". I have a shell script which does that and it is quite helpfull to have up-to-date "pending pull" identifiers as well as tags.
Comment 12 Dmitry Katsubo CLA 2018-09-04 10:24:18 EDT
Created attachment 275685 [details]
Pull multiple repositories report

I vote for this feature. However not only "Fetch from Upstream", but also "Push to Upstream" can be implemented in similar manner as for "Pull" (see attachment).