Bug 34845 - asserts do not need to be NLS'ed
Summary: asserts do not need to be NLS'ed
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 RC3   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-12 13:28 EST by John Wiegand CLA
Modified: 2003-03-19 11:56 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wiegand CLA 2003-03-12 13:28:42 EST 
20030307

JavaCore.newSourceEntry() includes two asserts that are NLSed.  asserts provide 
ISV information and are not presented to the user.  There is no need to NLS 
these strings.  This takes time, and just makes the logs more difficult to read.

		Assert.isTrue(path.isAbsolute(), Util.bind
("classpath.needAbsolutePath" )); //$NON-NLS-1$
		Assert.isTrue(exclusionPatterns != null, Util.bind
("classpath.nullExclusionPattern" )); //$NON-NLS-1$
Comment 1 Olivier Thomann CLA 2003-03-12 16:25:09 EST 
There are other occurrences of this patterns.
Comment 2 Philipe Mulet CLA 2003-03-13 11:24:51 EST 
Pls investigate how many we have. 

John - can we still change these for 2.1 ?
Comment 3 Olivier Thomann CLA 2003-03-13 11:35:51 EST 
14 occurences in JDT/Core. Do you want me to fix all of them?
Comment 4 John Wiegand CLA 2003-03-13 11:43:35 EST 
This is a low risk change.  Although the performance may not be measurable, it 
is still an improvement.  If you are comfortable making this change, I support 
doing it (you can count me as 1 vote for)
Comment 5 Philipe Mulet CLA 2003-03-13 11:50:35 EST 
Go ahead Olivier.
Comment 6 Olivier Thomann CLA 2003-03-13 12:30:12 EST 
I will also remove the NLS'ed messages from the Assert method isNotNull and isTrue.
Is this ok for you?
Comment 7 Olivier Thomann CLA 2003-03-13 12:38:13 EST 
Fixed and released in 2.1 stream.
Comment 8 David Audel CLA 2003-03-19 11:56:04 EST 
Verified.