Bug 34800 - [reconciling] Should not let reconciler thread running after shutdown
Summary: [reconciling] Should not let reconciler thread running after shutdown
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
: 58245 79351 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-03-12 06:57 EST by Jerome Lanneluc CLA
Modified: 2023-12-18 06:32 EST (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2003-03-12 06:57:17 EST
Build RC2

As shown in bug 33998, the reconciler thread is still running even after the 
JDT/UI plugin shutdown() has exited. It should wait for all reconciler threads 
to terminate before proceeding. See also bug 34069.
Comment 1 Erich Gamma CLA 2003-03-12 09:13:33 EST
Moving to JDT Text.

This behaviour was in since 1.0. So what are the symptoms of this problem? I 
don't think we should do such a change now unless there is a real problem.
Comment 2 Jerome Lanneluc CLA 2003-03-12 09:24:32 EST
There are currently no symptoms since bug 33998 was fixed to workaround the 
problem. In bug 34069 John Arthorne suggested that this could cause other grief.
Comment 3 John Arthorne CLA 2003-03-13 10:27:43 EST
Most runtime plugin API will throw assertion failures if you invoke methods 
after the runtime plugin has been shutdown.  The resources plugin API will fail 
in similar ways since we null our reference to the workspace during shutdown of 
the resources plugin.  There could be other side-effects of plugins shutting 
down out of order.


I agree this probably doesn't need to be addresed for 2.1 since there is a code 
work-around for the only known failure case.  You might want to revisit this for 
2.2 though.
Comment 4 Dani Megert CLA 2004-07-23 10:23:11 EDT
*** Bug 58245 has been marked as a duplicate of this bug. ***
Comment 5 Dani Megert CLA 2005-05-30 04:08:33 EDT
Deferring.
Comment 6 Dani Megert CLA 2005-06-16 06:23:07 EDT
Resetting priority to P3. Will be reassessed for the next release.
Comment 7 Dani Megert CLA 2006-03-22 05:25:23 EST
The problem is that waiting for the thread while closing the editor has drawbacks:
- making editor closing slower for the user even though this is not necessary
  assuming the reconciler silently dies in the background.
- can introducing deadlocks (see also bug 58245 comment 8)

There are currently no plans to address this for 3.2 but I've protected against the NPE reported by bug 58245.
Comment 8 Dani Megert CLA 2006-04-18 08:46:45 EDT
*** Bug 79351 has been marked as a duplicate of this bug. ***
Comment 9 Eclipse Genie CLA 2020-01-05 17:38:54 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 10 Eclipse Genie CLA 2021-12-27 13:00:24 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 11 Eclipse Genie CLA 2023-12-18 06:32:28 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.