Bug 347239 - many Indigo bundles missing legal files in RC2 repo
Summary: many Indigo bundles missing legal files in RC2 repo
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Cross-Project (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P1 blocker (vote)
Target Milestone: ---   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 347269 347325 347359 347407 347507 348747
Blocks:
  Show dependency tree
 
Reported: 2011-05-25 21:36 EDT by David Williams CLA
Modified: 2013-06-05 08:59 EDT (History)
21 users (show)

See Also:


Attachments
list from RC2 staging repo that are missing critical files (34.74 KB, text/plain)
2011-05-25 21:37 EDT, David Williams CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2011-05-25 21:36:07 EDT
I ran a "layout" test, and, according it it, about 10% of the bundles in the Indigo RC2 repo are missing about.html files (or, epl/license files, in features). 

These are often caused by incorrect "build.properties", or similar ... or, I'm sure, in some cases, really missing. 

That percentage seems "better" than last year ... but, still a lot to fix. I'll attach complete list. 

(And, remember ... it is possible the test is in error ... so if anyone finds an error in the reported list, be sure to let me know). 

Be sure to ask if questions or problems ... hopefully these can all be corrected for RC3.
Comment 1 David Williams CLA 2011-05-25 21:37:00 EDT
Created attachment 196616 [details]
list from RC2 staging repo that are missing critical files
Comment 2 David Williams CLA 2011-05-25 21:40:32 EDT
assigned to myself just to minimize mail notices (I won't be fixing them :) 

Also, meant to add ... this just checks "file system" so does not include "trusted repos" from Eclipse and EPP ... we assume they check their own. :) ... so that effects some "total number" statistics.
Comment 3 Laurent Goubet CLA 2011-05-26 03:45:57 EDT
The two that were missing from Acceleo and EMF Compare have now been fixed.
Comment 4 Eike Stepper CLA 2011-05-26 04:13:09 EDT
All the com.mongodb components are Apache licensed: http://dev.eclipse.org/ipzilla/show_bug.cgi?id=4889

Am I supposed to add the EPL in addition?
Comment 5 Christian Campo CLA 2011-05-26 05:44:26 EDT
fixed riena
Comment 6 Stephan Herrmann CLA 2011-05-26 07:20:35 EDT
I've fixed the 3 issues with Object Teams for RC3.
Comment 7 John Arthorne CLA 2011-05-26 08:48:10 EDT
I was surprised to see these 34 bundles:

Missing about.html in file: org.eclipse.e4.xwt.pde_0.9.1.v20101119-0800.jar
Missing about.html in file: org.eclipse.e4.xwt_0.9.1.v20101119-0800.jar

If you are not including the Eclipse top-level project in your scan, this suggests another project is distributing e4 bundles??
Comment 8 John Arthorne CLA 2011-05-26 08:48:42 EDT
(In reply to comment #7)
> I was surprised to see these 34 bundles:

(I meant e4, not 34)
Comment 9 David Williams CLA 2011-05-26 09:42:06 EDT
(In reply to comment #4)
> All the com.mongodb components are Apache licensed:
> http://dev.eclipse.org/ipzilla/show_bug.cgi?id=4889
> 
> Am I supposed to add the EPL in addition?

Not the "EPL license", per se ... but every features needs standard "Eclipse Software User Agreement" and every bundle requires an about.html that describes the license (and where to find the license) ... is my understanding. See 
http://www.eclipse.org/legal/guidetolegaldoc.php 
(and check with Eclipse IP Legal staff if that's not clear or if you have special cases).
Comment 10 David Williams CLA 2011-05-26 10:52:35 EDT
(In reply to comment #7)
> I was surprised to see these 34 bundles:
> 
> Missing about.html in file: org.eclipse.e4.xwt.pde_0.9.1.v20101119-0800.jar
> Missing about.html in file: org.eclipse.e4.xwt_0.9.1.v20101119-0800.jar
> 
> If you are not including the Eclipse top-level project in your scan, this
> suggests another project is distributing e4 bundles??

Yes. papyrus re-distributes these two. Which I know because of previous build breaks :) and, better, I just checked the log created during RC2 creation. You can search for "e4.xwt", seeing it being mirrored, and then "look up" in log to see what the last project repo was mentioned in log. 

So ... guess the question remains ... does e4 need the about.html file :) ... or are they just using an old, out of date file? 

Just FYI, I also noticed rg.eclipse.e4.core.di,0.9.0.v20100720-1930 in the log following gyrex. That's one thing we've learned about Eclipse over the years ... you never know who is doing what with your stuff :)
Comment 11 Martin Fluegge CLA 2011-05-26 13:14:50 EDT
I've fixed the CDO issues. Sorry for the mistake.
Comment 12 Bouchet Stéphane CLA 2011-05-27 03:04:42 EDT
fixed for EEF. will be available for RC3
Comment 13 Patrick Tessier CLA 2011-05-27 05:49:59 EDT
I have fixed for papyrus see bug 347407:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=347407
Comment 14 Kaloyan Raev CLA 2011-05-28 04:31:36 EDT
Libra bundles are fixed: bug 347507. Corrections will be available with the RC4 milestone.
Comment 15 Dennis Huebner CLA 2011-05-30 09:15:43 EDT
(In reply to comment #14)
> Libra bundles are fixed: bug 347507. Corrections will be available with the RC4
> milestone.

Xtext, Xpand, Xtend and MWE fixed  bug 347359.

@David How can I run your "layout" test against my repository. I would like to integrate it  into our build process.
Comment 16 Ralf Sternberg CLA 2011-05-31 19:17:22 EDT
The missing legal files in RAP have been fixed.

But there is one strange thing: The attached list contains two bundles from the sandbox in the RAP CVS which are not meant to be released in the Indigo repository. I'm not sure who includes these bundles but it's not RAP:

org.eclipse.rwt.widgets.upload.source_1.0.0.v20110503_R14-M7.jar
org.eclipse.rwt.widgets.upload_1.0.0.v20110503_R14-M7.jar

Is there a way to find out which feature includes these bundles?
Comment 17 Markus Knauer CLA 2011-06-01 01:34:07 EDT
(In reply to comment #16)
> org.eclipse.rwt.widgets.upload.source_1.0.0.v20110503_R14-M7.jar
> org.eclipse.rwt.widgets.upload_1.0.0.v20110503_R14-M7.jar
> 
> Is there a way to find out which feature includes these bundles?


http://download.eclipse.org/releases/staging/content.jar tells me that they are required by

org.eclipse.gyrex.admin.ui.http.jetty
org.eclipse.gyrex.admin.ui           -> optional==true
org.eclipse.gyrex.features.admin.feature.group
org.eclipse.gyrex.features.admin.source.feature.group
Comment 18 Achim Loerke CLA 2011-06-01 02:51:34 EDT
Fixed for Jubula in RC3
Comment 19 Adolfo Sanchez-Barbudo Herrera CLA 2011-06-01 07:35:08 EDT
Apologies,

I forgot to announce here that org.eclipse.ocl.examples.* bundles have been fixed (Bug 347327).

P.S: As David commented it was a matter of fixing the build.properties files.

Cheers,
Adolfo.
Comment 20 Cedric Brun CLA 2011-06-01 11:15:18 EDT
Fixed Modeling Amalgamation for RC3
Comment 21 Jun Ouyang CLA 2011-06-02 04:03:42 EDT
Fixed BIRT plugin org.eclipse.birt.report.engine.odf.
Comment 22 Matthias Zimmermann CLA 2011-06-02 06:28:15 EDT
fixed for Scout for RC4 (missing RC3)
Comment 23 David Williams CLA 2011-06-07 03:00:01 EDT
Progress is being made ... but slowly, considering this is last few days to fix. 

Still 5 features, almost 200 bundles. That's better than the 16 features and 400 bundles as of RC2 ... but ... I have a feeling we will be calling a few people at home. :) if they are not off the list soon. You can always see the most recent list at 

http://build.eclipse.org/indigo/simrel/reports/layoutCheck.txt

good luck!
Comment 24 Stephan Herrmann CLA 2011-06-07 07:11:18 EDT
(In reply to comment #23)
I've fixed the epl files for Object Teams for the second time:
first time I added epl-v1.0.html, now I know that the file name must not have 
a dot to mark version 1.0, sigh.
Comment 25 Laurent Goubet CLA 2011-06-07 07:21:46 EDT
Fixed for EMF Compare ... I forgot some of the plugins when I last checked :S.
Comment 26 Sabine Achilles CLA 2011-06-08 05:07:59 EDT
Fixed it for org.pushingpixels.trident, since Riena is probably the only project using it.
Comment 27 Vivian Kong CLA 2011-06-08 10:11:16 EDT
Fixed in CDT.  We will respin our RC4 to pick this up.
Comment 28 Sabine Achilles CLA 2011-06-09 03:19:36 EDT
Fixed it for org.eclipse.nebula.widgets.compositetable_1.0.0.jar.
Comment 29 David Williams CLA 2011-06-10 03:13:57 EDT
All clean in our RC4 repo
http://build.eclipse.org/indigo/simrel/


I looked at last years effort, see bug 316720. 

I was wrong about one thing, the percentage of bundles missing "legal files" was about the same both years, roughly 10%. 

And, if people thought this year was "last minute", last year these were discovered and fixed _after_ RC4, during quiet week, from 6/14 to 6/17. 
This year, the first report came out after RC2, on 5/25, but I think got lost during RC3 week due to the infrastructure issues. But, still a testament to everyone's ability and professionalism to get them fixed up by 6/10, before RC4 declared. 

Thanks everyone!