Community
Participate
Working Groups
I am heavily relied on disabling breakpoints and at many instances, accessing breakpoints properties (for setting conditions). The current way of doing these tasks are accessing the context menu of the breakpoint and choosing the appropriate menu-item. When I start doing these tasks repeatedly for multiple breakpoints at the same time, I am obsessed with the current way. I believe we can simplify these common tasks like - 1) Disable breakpoint : Ctrl+Click the breakpoint. 2) Access the breakpoint properties : Alt+Click the breakpoint. Alternatively, is there any better way of doing these tasks ?
This enhancement would require a fix to bug 71406, so that we can use modifier keys in the editor.
Created attachment 210010 [details] patch I know its test day, but I just could not resist trying to make this work... The patch provides support for: 1. Ctrl+double click -> enables / disables 2. Shift+double click -> opens the properties dialog on the breakpoint
Created attachment 210161 [details] Patch that uses IToggleBreakpointsTargetExtension2 I would like to hitch a feature I just filed in bug 369856 onto this bug ;-) Also, I think we should defer opening of the breakpoint properties dialog to the breakpoint model. CDT creates a custom context object for the properties dialog, and Wind River has a completely custom dialog.
(In reply to comment #3) > I would like to hitch a feature I just filed in bug 369856 onto this bug ;-) I think it would be better if we kept the two features separate.
Created attachment 210384 [details] Patch for jdt debug that implements opening breakpoint properties dialog using toggleBreakpointsItneractive. This patch uses the new API in bug 369856 to open breakpoint properties dialog when toggle action is invoked in editor with Shift key pressed.
Comment on attachment 210384 [details] Patch for jdt debug that implements opening breakpoint properties dialog using toggleBreakpointsItneractive. With the latest patch for bug 369856 no JDT plugin changes are needed.
Created attachment 211074 [details] platform patch This is a patch for platform debug that provides the new hooks to pass along the event to toggle adapters. The patch has a new API IToggleBreakpointsTargetExtension2 that has two new methods: canToggleBreakpointsWithEvent and toggleBreakpointsWithEvent.
Created attachment 211075 [details] JDT patch This patch implements the new API from the platform patch
+1 To commit these as is with one minor request: as a JDT user I'd prefer to have the Control key (MOD1) bring up dialog, and have Shift (MOD2) enable/disable. We use Control as a modifier to some of the launch menus to open the launch config. dialog, so this seems more consistent to me.
pushed the platform changes to: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=d8f49676d0842da03089b2ab50c237f16c66f1e4 pushed the JDT fixes to (with reversed modifier keys): http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=41610af0a7e296a9a25b80c6049b53a25aac883c
I'll definitely use this feature :-)
